[jira] Commented: (TS-130) we should generate a config.h file instead of putting all the -Ds in the CFLAGS

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831016#action_12831016 ] 

Leif Hedstrom commented on TS-130:
----------------------------------

Couple of questions still :)

1) What is DDebug ? Is that something new on the dev trunk too ? 

2) This patch looks better, but it still has a fair amount of changes that I'm not sure understand why they would be part of this bug / patch? They seem mostly cosmetic, e.g. changing CacheDebug to Debug (but also see the above about changes to DDebug). But there are some significant changes to DNS.cc for example in the v2 patch still, is that really intended?


> we should generate a config.h file instead of putting all the -Ds in the CFLAGS
> -------------------------------------------------------------------------------
>
>                 Key: TS-130
>                 URL: https://issues.apache.org/jira/browse/TS-130
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: John Plevyak
>            Assignee: John Plevyak
>         Attachments: config.h-jp-v1.patch, ts-config.h-jp-v2.patch
>
>
> We should use a config.h instead of a huge pile of -Ds

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.