[GitHub] sijie closed pull request #1670: Remove unnecessary log statement in LedgerDirsManager.getWritableLedgerDirs

[GitBox <gi...@apache.org>]

sijie closed pull request #1670: Remove unnecessary log statement in LedgerDirsManager.getWritableLedgerDirs
URL: https://github.com/apache/bookkeeper/pull/1670
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsManager.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsManager.java
index cdaa66814b..5fb8215f09 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsManager.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsManager.java
@@ -157,7 +157,6 @@ public long getTotalDiskSpace(List<File> dirs) throws IOException {
             String errMsg = "All ledger directories are non writable";
             NoWritableLedgerDirException e = new NoWritableLedgerDirException(
                     errMsg);
-            LOG.error(errMsg, e);
             throw e;
         }
         return writableLedgerDirectories;
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsMonitor.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsMonitor.java
index 4ef02fae4d..fedebb7422 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsMonitor.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsMonitor.java
@@ -108,6 +108,7 @@ private void check() {
             // bookie cannot get writable dir but considered to be writable
             ldm.getWritableLedgerDirs();
         } catch (NoWritableLedgerDirException e) {
+            LOG.warn("LedgerDirsMonitor check process: All ledger directories are non writable");
             boolean highPriorityWritesAllowed = true;
             try {
                 // disk check can be frequent, so disable 'loggingNoWritable' to avoid log flooding.


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services