Using JdbcDataSourceName with Quickfix component

[maroos <ma...@gmail.com>]

Hi,
I want Quickfix/J to use JdbcDataSourceName rather than JdbcDriver+JdbcURL
to access JDBC Message Store.
However the latest version of the Quickfix component (2.9.2) checks only if
the SETTING_JDBC_DRIVER is present in the settings and if it's not then it
defaults to MemoryStore. It ignores SETTING_JDBC_DS_NAME entirely, see the
following method in QuickfixjEngine:


Am I missing something? If not then probably the solution is trivial - the
if statement should be extended to check the SETTING_JDBC_DS_NAME as well.

Best regards,
Marek

--
View this message in context: http://camel.465427.n5.nabble.com/Using-JdbcDataSourceName-with-Quickfix-component-tp5659708p5659708.html
Sent from the Camel - Users mailing list archive at Nabble.com.

Re: Using JdbcDataSourceName with Quickfix component

[Claus Ibsen <cl...@gmail.com>]

On Mon, Apr 30, 2012 at 5:32 PM, Marek Strejczek
<ma...@gmail.com> wrote:
> Thank you for quick response and action.
> I see another problem with Quickfix engine configuration - if a setting
> (e.g. SETTING_JDBC_DS_NAME) is in a non-default section of the config file
> (i.e. [Session]) then it is not recognized by Camel.
> I guess it is because the SessionSettings.isSetting method checks only the
> [Default] part of the settings.
> This issue is a bit trickier to solve. If you confirm that it's a problem
> then I'll raise a JIRA issue and can work on the patch next.
>

Yeah fell free to log a JIRA and work on a patch. After all we love
contributions.


> BR,
> Marek
>
>
> --
> View this message in context: http://camel.465427.n5.nabble.com/Using-JdbcDataSourceName-with-Quickfix-component-tp5659708p5676219.html
> Sent from the Camel - Users mailing list archive at Nabble.com.



-- 
Claus Ibsen
-----------------
CamelOne 2012 Conference, May 15-16, 2012: http://camelone.com
FuseSource
Email: cibsen@fusesource.com
Web: http://fusesource.com
Twitter: davsclaus, fusenews
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/

Re: Using JdbcDataSourceName with Quickfix component

[Marek Strejczek <ma...@gmail.com>]

Thank you for quick response and action.
I see another problem with Quickfix engine configuration - if a setting
(e.g. SETTING_JDBC_DS_NAME) is in a non-default section of the config file
(i.e. [Session]) then it is not recognized by Camel. 
I guess it is because the SessionSettings.isSetting method checks only the
[Default] part of the settings.
This issue is a bit trickier to solve. If you confirm that it's a problem
then I'll raise a JIRA issue and can work on the patch next.

BR,
Marek


--
View this message in context: http://camel.465427.n5.nabble.com/Using-JdbcDataSourceName-with-Quickfix-component-tp5659708p5676219.html
Sent from the Camel - Users mailing list archive at Nabble.com.

Re: Using JdbcDataSourceName with Quickfix component

[Christian Müller <ch...@gmail.com>]

I opened the issue [1] and fixed it already.

[1] https://issues.apache.org/jira/browse/CAMEL-5220

Best,
Christian

On Mon, Apr 23, 2012 at 6:31 PM, Claus Ibsen <cl...@gmail.com> wrote:

> On Mon, Apr 23, 2012 at 5:40 PM, maroos <ma...@gmail.com> wrote:
> > Hi,
> > I want Quickfix/J to use JdbcDataSourceName rather than
> JdbcDriver+JdbcURL
> > to access JDBC Message Store.
> > However the latest version of the Quickfix component (2.9.2) checks only
> if
> > the SETTING_JDBC_DRIVER is present in the settings and if it's not then
> it
> > defaults to MemoryStore. It ignores SETTING_JDBC_DS_NAME entirely, see
> the
> > following method in QuickfixjEngine:
> >
> >
> > Am I missing something? If not then probably the solution is trivial -
> the
> > if statement should be extended to check the SETTING_JDBC_DS_NAME as
> well.
> >
>
> Hi
>
> Its most likely a feature we currently not support. As we love
> contributions, feel free to log a JIRA ticket
> and work on a patch if you got the time. Having unit test with the
> patch would be lovely.
> http://camel.apache.org/contributing.html
>
>
>
> > Best regards,
> > Marek
> >
> > --
> > View this message in context:
> http://camel.465427.n5.nabble.com/Using-JdbcDataSourceName-with-Quickfix-component-tp5659708p5659708.html
> > Sent from the Camel - Users mailing list archive at Nabble.com.
>
>
>
> --
> Claus Ibsen
> -----------------
> CamelOne 2012 Conference, May 15-16, 2012: http://camelone.com
> FuseSource
> Email: cibsen@fusesource.com
> Web: http://fusesource.com
> Twitter: davsclaus, fusenews
> Blog: http://davsclaus.blogspot.com/
> Author of Camel in Action: http://www.manning.com/ibsen/
>

Re: Using JdbcDataSourceName with Quickfix component

[Claus Ibsen <cl...@gmail.com>]

On Mon, Apr 23, 2012 at 5:40 PM, maroos <ma...@gmail.com> wrote:
> Hi,
> I want Quickfix/J to use JdbcDataSourceName rather than JdbcDriver+JdbcURL
> to access JDBC Message Store.
> However the latest version of the Quickfix component (2.9.2) checks only if
> the SETTING_JDBC_DRIVER is present in the settings and if it's not then it
> defaults to MemoryStore. It ignores SETTING_JDBC_DS_NAME entirely, see the
> following method in QuickfixjEngine:
>
>
> Am I missing something? If not then probably the solution is trivial - the
> if statement should be extended to check the SETTING_JDBC_DS_NAME as well.
>

Hi

Its most likely a feature we currently not support. As we love
contributions, feel free to log a JIRA ticket
and work on a patch if you got the time. Having unit test with the
patch would be lovely.
http://camel.apache.org/contributing.html



> Best regards,
> Marek
>
> --
> View this message in context: http://camel.465427.n5.nabble.com/Using-JdbcDataSourceName-with-Quickfix-component-tp5659708p5659708.html
> Sent from the Camel - Users mailing list archive at Nabble.com.



-- 
Claus Ibsen
-----------------
CamelOne 2012 Conference, May 15-16, 2012: http://camelone.com
FuseSource
Email: cibsen@fusesource.com
Web: http://fusesource.com
Twitter: davsclaus, fusenews
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/