You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/23 16:49:24 UTC

[GitHub] [flink] sjwiesman opened a new pull request #12970: [FLINK-18341][walkthroughs] Drop remaining table walkthrough archetypes

sjwiesman opened a new pull request #12970:
URL: https://github.com/apache/flink/pull/12970


   #  What is the purpose of the change
   
   Remove unused walkthrough components that are causing build instability. 
   
   ## Brief change log
   
   - Delete unstable code
   
   
   ## Verifying this change 
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
   No
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12970: [FLINK-18341][walkthroughs] Drop remaining table walkthrough archetypes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12970:
URL: https://github.com/apache/flink/pull/12970#issuecomment-663126281


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29d992adaad37d914a272df74642ff740dd84e1e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "29d992adaad37d914a272df74642ff740dd84e1e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6b557f3c579efd309884b9abc9037bc224fd4086",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6b557f3c579efd309884b9abc9037bc224fd4086",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29d992adaad37d914a272df74642ff740dd84e1e UNKNOWN
   * 6b557f3c579efd309884b9abc9037bc224fd4086 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #12970: [FLINK-18341][walkthroughs] Drop remaining table walkthrough archetypes

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12970:
URL: https://github.com/apache/flink/pull/12970#issuecomment-663126281


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29d992adaad37d914a272df74642ff740dd84e1e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "29d992adaad37d914a272df74642ff740dd84e1e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29d992adaad37d914a272df74642ff740dd84e1e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dianfu commented on pull request #12970: [FLINK-18341][walkthroughs] Drop remaining table walkthrough archetypes

Posted by GitBox <gi...@apache.org>.
dianfu commented on pull request #12970:
URL: https://github.com/apache/flink/pull/12970#issuecomment-663324805


   @sjwiesman Thanks for the PR. LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #12970: [FLINK-18341][walkthroughs] Drop remaining table walkthrough archetypes

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12970:
URL: https://github.com/apache/flink/pull/12970#issuecomment-663116539


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 39999b29e84cd3174fb2b982b8005d48e4893e60 (Thu Jul 23 16:52:29 UTC 2020)
   
   **Warnings:**
    * **6 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12970: [FLINK-18341][walkthroughs] Drop remaining table walkthrough archetypes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12970:
URL: https://github.com/apache/flink/pull/12970#issuecomment-663126281


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29d992adaad37d914a272df74642ff740dd84e1e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "29d992adaad37d914a272df74642ff740dd84e1e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6b557f3c579efd309884b9abc9037bc224fd4086",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4829",
       "triggerID" : "6b557f3c579efd309884b9abc9037bc224fd4086",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29d992adaad37d914a272df74642ff740dd84e1e UNKNOWN
   * 6b557f3c579efd309884b9abc9037bc224fd4086 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4829) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12970: [FLINK-18341][walkthroughs] Drop remaining table walkthrough archetypes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12970:
URL: https://github.com/apache/flink/pull/12970#issuecomment-663126281


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6b557f3c579efd309884b9abc9037bc224fd4086",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4829",
       "triggerID" : "6b557f3c579efd309884b9abc9037bc224fd4086",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6b557f3c579efd309884b9abc9037bc224fd4086 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4829) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12970: [FLINK-18341][walkthroughs] Drop remaining table walkthrough archetypes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12970:
URL: https://github.com/apache/flink/pull/12970#issuecomment-663126281


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29d992adaad37d914a272df74642ff740dd84e1e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "29d992adaad37d914a272df74642ff740dd84e1e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6b557f3c579efd309884b9abc9037bc224fd4086",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4829",
       "triggerID" : "6b557f3c579efd309884b9abc9037bc224fd4086",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29d992adaad37d914a272df74642ff740dd84e1e UNKNOWN
   * 6b557f3c579efd309884b9abc9037bc224fd4086 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4829) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] sjwiesman closed pull request #12970: [FLINK-18341][walkthroughs] Drop remaining table walkthrough archetypes

Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #12970:
URL: https://github.com/apache/flink/pull/12970


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org