Re: svn commit: r12859 - trunk/subversion/clients/cmdline

[Julian Foad <ju...@btopenworld.com>]

kfogel@collab.net wrote:
>>+svn_error_t *svn_cl__error_checked_fputs (const char *string,
>>+                                          FILE* stream);
> 
> We usually write "FILE *stream", w/ space before star instead of after.

Oh yes.  And in the implementation file too.  I just moved existing code, 
noticing that it needed a space before the opening parenthesis, but not 
noticing that.  It's not worth a separate commit just to fix that.

> Didn't see anything suspicious in the rest of the commit.  Thanks for
> doing this!

Thanks for the review.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org