You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/08/01 07:59:03 UTC
[GitHub] [incubator-pekko-connectors] mdedetrich opened a new pull request, #208: Add sbt-header to code style checks
mdedetrich opened a new pull request, #208:
URL: https://github.com/apache/incubator-pekko-connectors/pull/208
Forgot to do this in previous PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #208: Add sbt-header to code style checks
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #208:
URL: https://github.com/apache/incubator-pekko-connectors/pull/208#discussion_r1294347641
##########
build.sbt:
##########
@@ -129,8 +129,8 @@ lazy val `pekko-connectors` = project
crossScalaVersions := List() // workaround for https://github.com/sbt/sbt/issues/3465
)
-addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll")
-addCommandAlias("checkCodeStyle", ";scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll; +headerCheckAll")
+addCommandAlias("checkCodeStyle", "+headerCreateAll; ;scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
Review Comment:
Ah I see, missed it doing it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] He-Pin commented on a diff in pull request #208: Add sbt-header to code style checks
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #208:
URL: https://github.com/apache/incubator-pekko-connectors/pull/208#discussion_r1294331081
##########
build.sbt:
##########
@@ -129,8 +129,8 @@ lazy val `pekko-connectors` = project
crossScalaVersions := List() // workaround for https://github.com/sbt/sbt/issues/3465
)
-addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll")
-addCommandAlias("checkCodeStyle", ";scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll; +headerCheckAll")
+addCommandAlias("checkCodeStyle", "+headerCreateAll; ;scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
Review Comment:
@mdedetrich I'm Ok with both name,but better to keep consistence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #208: Add sbt-header to code style checks
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #208:
URL: https://github.com/apache/incubator-pekko-connectors/pull/208#discussion_r1294335106
##########
build.sbt:
##########
@@ -129,8 +129,8 @@ lazy val `pekko-connectors` = project
crossScalaVersions := List() // workaround for https://github.com/sbt/sbt/issues/3465
)
-addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll")
-addCommandAlias("checkCodeStyle", ";scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll; +headerCheckAll")
+addCommandAlias("checkCodeStyle", "+headerCreateAll; ;scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
Review Comment:
Agreed, considering that pekko is the odd one out are you fine with me changing it there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #208: Add sbt-header to code style checks
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #208:
URL: https://github.com/apache/incubator-pekko-connectors/pull/208#discussion_r1294236631
##########
build.sbt:
##########
@@ -129,8 +129,8 @@ lazy val `pekko-connectors` = project
crossScalaVersions := List() // workaround for https://github.com/sbt/sbt/issues/3465
)
-addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll")
-addCommandAlias("checkCodeStyle", ";scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll; +headerCheckAll")
+addCommandAlias("checkCodeStyle", "+headerCreateAll; ;scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
Review Comment:
I guess we should use a common name, I prefer checkCodeStyle. If you agree should I just make a PR in pekko to change it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich merged pull request #208: Add sbt-header to code style checks
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #208:
URL: https://github.com/apache/incubator-pekko-connectors/pull/208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #208: Add sbt-header to code style checks
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #208:
URL: https://github.com/apache/incubator-pekko-connectors/pull/208#issuecomment-1675782849
> need to change and add `+`
@He-Pin fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #208: Add sbt-header to code style checks
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #208:
URL: https://github.com/apache/incubator-pekko-connectors/pull/208#discussion_r1294348471
##########
build.sbt:
##########
@@ -129,8 +129,8 @@ lazy val `pekko-connectors` = project
crossScalaVersions := List() // workaround for https://github.com/sbt/sbt/issues/3465
)
-addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll")
-addCommandAlias("checkCodeStyle", ";scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll; +headerCheckAll")
+addCommandAlias("checkCodeStyle", "+headerCreateAll; ;scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
Review Comment:
Fixed and pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] He-Pin commented on a diff in pull request #208: Add sbt-header to code style checks
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #208:
URL: https://github.com/apache/incubator-pekko-connectors/pull/208#discussion_r1281435965
##########
build.sbt:
##########
@@ -129,8 +129,8 @@ lazy val `pekko-connectors` = project
crossScalaVersions := List() // workaround for https://github.com/sbt/sbt/issues/3465
)
-addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll")
-addCommandAlias("checkCodeStyle", ";scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll; headerCheckAll")
+addCommandAlias("checkCodeStyle", "headerCreateAll; ;scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
Review Comment:
headerCreateAll should in `applyCodeStyle`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] He-Pin commented on a diff in pull request #208: Add sbt-header to code style checks
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #208:
URL: https://github.com/apache/incubator-pekko-connectors/pull/208#discussion_r1293105853
##########
build.sbt:
##########
@@ -129,8 +129,8 @@ lazy val `pekko-connectors` = project
crossScalaVersions := List() // workaround for https://github.com/sbt/sbt/issues/3465
)
-addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll")
-addCommandAlias("checkCodeStyle", ";scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll; +headerCheckAll")
Review Comment:
+headerCreateAll
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] He-Pin commented on a diff in pull request #208: Add sbt-header to code style checks
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #208:
URL: https://github.com/apache/incubator-pekko-connectors/pull/208#discussion_r1294260732
##########
build.sbt:
##########
@@ -129,8 +129,8 @@ lazy val `pekko-connectors` = project
crossScalaVersions := List() // workaround for https://github.com/sbt/sbt/issues/3465
)
-addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll")
-addCommandAlias("checkCodeStyle", ";scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll; +headerCheckAll")
+addCommandAlias("checkCodeStyle", "+headerCreateAll; ;scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
Review Comment:
@mdedetrich you need still update the `+headerCreateAll` to `+headerCheckAll`
##########
build.sbt:
##########
@@ -129,8 +129,8 @@ lazy val `pekko-connectors` = project
crossScalaVersions := List() // workaround for https://github.com/sbt/sbt/issues/3465
)
-addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll")
-addCommandAlias("checkCodeStyle", ";scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll; +headerCheckAll")
+addCommandAlias("checkCodeStyle", "+headerCreateAll; ;scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
Review Comment:
@mdedetrich you need update the `+headerCreateAll` to `+headerCheckAll`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] He-Pin commented on a diff in pull request #208: Add sbt-header to code style checks
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #208:
URL: https://github.com/apache/incubator-pekko-connectors/pull/208#discussion_r1293110572
##########
build.sbt:
##########
@@ -129,8 +129,8 @@ lazy val `pekko-connectors` = project
crossScalaVersions := List() // workaround for https://github.com/sbt/sbt/issues/3465
)
-addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll")
-addCommandAlias("checkCodeStyle", ";scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll; +headerCheckAll")
+addCommandAlias("checkCodeStyle", "+headerCreateAll; ;scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
Review Comment:
`verifyCodeStyle` same as pekko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] He-Pin commented on a diff in pull request #208: Add sbt-header to code style checks
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #208:
URL: https://github.com/apache/incubator-pekko-connectors/pull/208#discussion_r1294351147
##########
build.sbt:
##########
@@ -129,8 +129,8 @@ lazy val `pekko-connectors` = project
crossScalaVersions := List() // workaround for https://github.com/sbt/sbt/issues/3465
)
-addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll")
-addCommandAlias("checkCodeStyle", ";scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll; +headerCheckAll")
+addCommandAlias("checkCodeStyle", "+headerCreateAll; ;scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
Review Comment:
@mdedetrich maybe that wil confuse some one contribute to both project?I mean akka & pekko, I saw @dongxuwang did the same too.
##########
build.sbt:
##########
@@ -129,8 +129,8 @@ lazy val `pekko-connectors` = project
crossScalaVersions := List() // workaround for https://github.com/sbt/sbt/issues/3465
)
-addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll")
-addCommandAlias("checkCodeStyle", ";scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll; +headerCheckAll")
+addCommandAlias("checkCodeStyle", "+headerCreateAll; ;scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
Review Comment:
@mdedetrich maybe that will confuse some one contribute to both project?I mean akka & pekko, I saw @dongxuwang did the same too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] He-Pin commented on a diff in pull request #208: Add sbt-header to code style checks
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #208:
URL: https://github.com/apache/incubator-pekko-connectors/pull/208#discussion_r1293106056
##########
build.sbt:
##########
@@ -129,8 +129,8 @@ lazy val `pekko-connectors` = project
crossScalaVersions := List() // workaround for https://github.com/sbt/sbt/issues/3465
)
-addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll")
-addCommandAlias("checkCodeStyle", ";scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll; +headerCheckAll")
+addCommandAlias("checkCodeStyle", "+headerCreateAll; ;scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
Review Comment:
+headerCheckAll
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org