You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/08/03 15:20:10 UTC

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1149: MINIFICPP-1038 - Update paho.mqtt.c to a released version

szaszm commented on a change in pull request #1149:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1149#discussion_r681862183



##########
File path: cmake/BundledPahoMqttC.cmake
##########
@@ -45,7 +45,7 @@ function(use_bundled_pahomqttc SOURCE_DIR BINARY_DIR)
     ExternalProject_Add(
             paho.mqtt.c-external
             GIT_REPOSITORY "https://github.com/eclipse/paho.mqtt.c.git"
-            GIT_TAG "6aa07f575bc9369402b1b252fd280373f8d585ef" # This is not a tagged/released version, but the exact one that was in our repo.
+            GIT_TAG "3b7ae6348bc917d42c04efa962e4868c09bbde9f" # Once tagged as v1.3.9 release, but tags may move

Review comment:
       Tags can't move AFAIK, so I'd go with the tag name for simplicity




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org