You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/12 08:08:52 UTC

[GitHub] [apisix-ingress-controller] tokers commented on pull request #745: feat: support environment variable in config file

tokers commented on pull request #745:
URL: https://github.com/apache/apisix-ingress-controller/pull/745#issuecomment-966904285


   > The code LGTM. Thanks!
   > 
   > But I personally prefer to directly support configuration through environment variables or through configuration files Instead of supporting environment variables in the configuration file.
   > 
   > WDYT? @gxthrj @tokers @lilien1010
   
   Softwares like ETCD and Istio support using environment variables directly, and the precedence is highest, so it's my understanding that we do should support environment variables, configuration file and command line options.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org