You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "strongduanmu (via GitHub)" <gi...@apache.org> on 2023/04/19 08:55:45 UTC
[GitHub] [shardingsphere] strongduanmu opened a new issue, #25232: Add unit test for ShardingLoadDataStatementValidator and ShardingLoadXMLStatementValidator
strongduanmu opened a new issue, #25232:
URL: https://github.com/apache/shardingsphere/issues/25232
This issue is to add unit tests for the ShardingLoadDataStatementValidator and ShardingLoadXMLStatementValidator, it includes the following subtasks:
- [ ] ShardingLoadDataStatementValidator#preValidate
- [ ] ShardingLoadXMLStatementValidator#preValidate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] liuxiaocs7 commented on issue #25232: Add unit test for ShardingLoadDataStatementValidator and ShardingLoadXMLStatementValidator
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on issue #25232:
URL: https://github.com/apache/shardingsphere/issues/25232#issuecomment-1515068507
Hi, @strongduanmu, i want to have a try, plz assign to me, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] liuxiaocs7 commented on issue #25232: Add unit test for ShardingLoadDataStatementValidator and ShardingLoadXMLStatementValidator
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on issue #25232:
URL: https://github.com/apache/shardingsphere/issues/25232#issuecomment-1515618477
Hi, @strongduanmu, thanks for your revise(#25248), the code looks more clear and concise, I would like to ask why the extra space/Tab is needed
BTW, could you tell me where can I continue to learn the code norms of the community?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #25232: Add unit test for ShardingLoadDataStatementValidator and ShardingLoadXMLStatementValidator
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #25232:
URL: https://github.com/apache/shardingsphere/issues/25232#issuecomment-1515622775
Hi @liuxiaocs7, can you read ShardingSphere code conduct first - https://shardingsphere.apache.org/community/en/involved/conduct/code/. Besides, you can execute `mvn spotless:apply` to format code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #25232: Add unit test for ShardingLoadDataStatementValidator and ShardingLoadXMLStatementValidator
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #25232:
URL: https://github.com/apache/shardingsphere/issues/25232#issuecomment-1515583669
@liuxiaocs7 Welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] liuxiaocs7 commented on issue #25232: Add unit test for ShardingLoadDataStatementValidator and ShardingLoadXMLStatementValidator
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on issue #25232:
URL: https://github.com/apache/shardingsphere/issues/25232#issuecomment-1516158325
> Hi @liuxiaocs7, can you read ShardingSphere code conduct first - https://shardingsphere.apache.org/community/en/involved/conduct/code/. Besides, you can execute `mvn spotless:apply` to format code.
Got it, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu closed issue #25232: Add unit test for ShardingLoadDataStatementValidator and ShardingLoadXMLStatementValidator
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu closed issue #25232: Add unit test for ShardingLoadDataStatementValidator and ShardingLoadXMLStatementValidator
URL: https://github.com/apache/shardingsphere/issues/25232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org