You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/01/24 11:48:21 UTC
[GitHub] [skywalking-rocketbot-ui] Fine0830 opened a new pull request #417: Feat: Implement service logs in ui
Fine0830 opened a new pull request #417:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/417
Implement service logs in ui. Reference https://github.com/apache/skywalking/issues/5930
Screenshots
Signed-off-by: Qiuxia Fan <qi...@apache.org>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #417: Feat: Implement service logs in ui
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #417:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/417#issuecomment-766767640
Please recheck
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng merged pull request #417: Feat: Implement service logs in ui
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #417:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng merged pull request #417: Feat: Implement service logs in ui
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #417:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #417: Feat: Implement service logs in ui
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #417:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/417#issuecomment-766496702
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #417: Feat: Implement service logs in ui
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #417:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/417#issuecomment-766497697
> 2. We need to add 2 buttons to support visualizing trace related logs on the trace and span page. At there, we use `trace_id` and `trace_id + segment_id + span_id` to open a new pop up page to show.
I will handle this in another pr to make this pr smaller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #417: Feat: Implement service logs in ui
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #417:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/417#issuecomment-766496702
> 1. Let's keep the trace Id at the last column in the main page.
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #417: Feat: Implement service logs in ui
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #417:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/417#issuecomment-766339484
1. Let's keep the trace Id at the last column in the main page.
2. We need to add 2 buttons to support visualizing trace related logs on the trace and span page. At there, we use `trace_id` and `trace_id + segment_id + span_id` to open a new pop up page to show.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org