You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2013/04/04 16:15:19 UTC
[jira] [Updated] (SOLR-4663) Log an error if more than one core
points to the same data dir.
[ https://issues.apache.org/jira/browse/SOLR-4663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated SOLR-4663:
---------------------------------
Attachment: SOLR-4663.patch
Here's a patch. It fixes another issue I saw with persisting (I'll be soooo glad when that's obsoleted!).
It fails hard when either a core with a duplicate name is found or with a duplicate data dir, both with old and new style solr.xml. It's still possible for more than one core to share the same instance dir. I'd guess there are other checks that could be done, but this is a start.
My real question is whether it's appropriate to fail hard on startup or just log a very loud warning. Ryan's the only person who's weighed in on this so far. My preference is to fail hard but I'm not particularly invested either way.
I'll be checking this in tomorrow at the latest unless there are objections.
> Log an error if more than one core points to the same data dir.
> ---------------------------------------------------------------
>
> Key: SOLR-4663
> URL: https://issues.apache.org/jira/browse/SOLR-4663
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.3, 5.0
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: SOLR-4663.patch
>
>
> In large multi-core setups, having mistakes whereby two or more cores point to the same data dir seems quite possible. We should at least complain very loudly in the logs if this is detected.
> Should be a very straightforward check at core discovery time.
> Is this serious enough to keep Solr from coming up at all?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org