[GitHub] [superset] john-bodley commented on a diff in pull request #23856: fix(tests): Ensure deterministic CSV select

["john-bodley (via GitHub)" <gi...@apache.org>]

john-bodley commented on code in PR #23856:
URL: https://github.com/apache/superset/pull/23856#discussion_r1179639389


##########
tests/integration_tests/csv_upload_tests.py:
##########
@@ -556,4 +561,4 @@ def test_import_parquet(mock_event_logger):
 
     with test_db.get_sqla_engine_with_context() as engine:
         data = engine.execute(f"SELECT * from {PARQUET_UPLOAD_TABLE}").fetchall()
-        assert data == [("max", 3), ("bob", 4), ("john", 1), ("paul", 2)]
+        assert data == [("john", 1), ("paul", 2), ("max", 3), ("bob", 4)]

Review Comment:
   @betodealmeida I've re-authored the PR based on your comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org