You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by jrushford <gi...@git.apache.org> on 2016/04/12 22:34:15 UTC
[GitHub] trafficserver pull request: TS-4067: Memory leaks in parent select...
GitHub user jrushford opened a pull request:
https://github.com/apache/trafficserver/pull/566
TS-4067: Memory leaks in parent selection regression tests.
Fixed most of the memory leaks in the ParentSelection regression tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jrushford/trafficserver ts4067
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/566.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #566
----
commit 8792abaaaca23951c22cd822eb67d7e59379d156
Author: jrushf1239k <jo...@cable.comcast.com>
Date: 2016-04-12T20:28:28Z
TS-4067: Memory leaks in parent selection regression tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4067: Memory leaks in parent select...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/566#issuecomment-209512558
This looks better. @jrushford can you please wrap these macros in a ```do { ... } while (0)``` block? They are giving me the heebie-jeebies.
Could you consider rewriting these tests to be more structured and maintainable?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4067: Memory leaks in parent select...
Posted by jrushford <gi...@git.apache.org>.
Github user jrushford commented on the pull request:
https://github.com/apache/trafficserver/pull/566#issuecomment-209441767
@jpeach and @zwoop I modified the regression test REBUILD and REINIT macros and added code to free allocated memory. This eliminated all the parent selection regression test memory leaks identified using libgmalloc and leaks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4067: Memory leaks in parent select...
Posted by jrushford <gi...@git.apache.org>.
Github user jrushford commented on the pull request:
https://github.com/apache/trafficserver/pull/566#issuecomment-209520959
@jpeach, I'll wrap these macros in the do {...} while(0) block, good idea. I'll think about the re-write in the future but, I have some other things that are higher priority. Are you +1 on landing this after the do {} while(0) changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4067: Memory leaks in parent select...
Posted by jrushford <gi...@git.apache.org>.
Github user jrushford closed the pull request at:
https://github.com/apache/trafficserver/pull/566
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4067: Memory leaks in parent select...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/566#issuecomment-209521176
Yes that sounds fine, thanks @jrushford
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---