You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/11/15 04:31:04 UTC

[GitHub] [helix] narendly opened a new pull request #606: Modify ZkUtil methods so that they accept ZkAddress as parameter

narendly opened a new pull request #606: Modify ZkUtil methods so that they accept ZkAddress as parameter
URL: https://github.com/apache/helix/pull/606
 
 
   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the PR description:
   
   Resolves #605 
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Replace methods in ZkUtil so that it does not require HelixZkClient
   
   This is so that the users of ZkUtil do not have to create HelixZkClient to use the utility methods.
   
   ### Tests
   
   - [x] The following tests are written for this issue:
   
   Covered by TestZKUtil.java
   
   - [ ] The following is the result of the "mvn test" command on the appropriate module:
   
   (Copy & paste the result of "mvn test")
   
   ### Commits
   
   - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   
   ### Code Quality
   
   - [x] My diff has been formatted using helix-style.xml

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org