You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/08/11 17:52:04 UTC
[GitHub] [superset] justinpark opened a new pull request, #24965: fix(sqllab): scroll position after run current sql
justinpark opened a new pull request, #24965:
URL: https://github.com/apache/superset/pull/24965
### SUMMARY
The scroll position after run current sql(ctrl + shift + enter) moved to bottom when hit within the first paragraph.
This commit fixes this bug by storing the current scroll after running the query.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
https://github.com/apache/superset/assets/1392866/549b2744-9b5e-4692-85c4-22444e01f58a
Before:
https://github.com/apache/superset/assets/1392866/fb0dace9-9d80-4ec7-8b86-ad2a15a82497
### TESTING INSTRUCTIONS
- type multiple sqls in the editor that makes scrollbars
- hit running current query in the first sql paragraph
- check the current position of the scrollbar after that
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24965: fix(sqllab): scroll position after run current sql
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24965:
URL: https://github.com/apache/superset/pull/24965#issuecomment-1677276307
Query is failing when running without selecting the whole query.
https://github.com/apache/superset/assets/70410625/fa60b683-55f3-4735-bc6b-0c86a57d6063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #24965: fix(sqllab): scroll position after run current sql
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24965:
URL: https://github.com/apache/superset/pull/24965#issuecomment-1675292860
@michael-s-molina Ephemeral environment spinning up at http://35.86.122.33:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #24965: fix(sqllab): scroll position after run current sql
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #24965:
URL: https://github.com/apache/superset/pull/24965#issuecomment-1677703291
> Query is failing when running without selecting the whole query.
This is not a bug. you missed the semicolon in the first sql block
```
select *
from 'fcc survey"
where is_software_dev = 1 <-------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #24965: fix(sqllab): scroll position after run current sql
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24965:
URL: https://github.com/apache/superset/pull/24965#issuecomment-1679359082
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24965: fix(sqllab): scroll position after run current sql
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24965:
URL: https://github.com/apache/superset/pull/24965#issuecomment-1675290728
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark merged pull request #24965: fix(sqllab): scroll position after run current sql
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark merged PR #24965:
URL: https://github.com/apache/superset/pull/24965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #24965: fix(sqllab): scroll position after run current sql
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #24965:
URL: https://github.com/apache/superset/pull/24965#issuecomment-1677703102
> Query is failing when running without selecting the whole query.
This is not a bug. you missed the semicolon in the first sql block
```
select *
from 'fcc survey"
where is_software_dev = 1 <-------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org