[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #7462: feat: Add `validate_sql_json` endpoint for checking that a given sql …

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #7462: feat: Add `validate_sql_json` endpoint for checking that a given sql …
URL: https://github.com/apache/incubator-superset/pull/7462#discussion_r281869227
 
 

 ##########
 File path: superset/sql_validators/presto_db.py
 ##########
 @@ -0,0 +1,186 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from contextlib import closing
+import logging
+import time
+from typing import (
+    Any,
+    Dict,
+    List,
+    Optional,
+)
+
+from flask import g
+from pyhive.exc import DatabaseError
 
 Review comment:
   `pyhive` is an optional package, fix here: https://github.com/apache/incubator-superset/pull/7471

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org