You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "J.W. Janssen (JIRA)" <ji...@apache.org> on 2012/10/09 13:08:02 UTC

[jira] [Created] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

J.W. Janssen created SHINDIG-1878:
-------------------------------------

             Summary: Discrepancy between OpenSocial spec 2.5 and Shindig 
                 Key: SHINDIG-1878
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
             Project: Shindig
          Issue Type: Bug
    Affects Versions: 2.5.0-beta4
            Reporter: J.W. Janssen


Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out below.

Primary Social Data:

Activity
	entity is deprecated
	titleId field no longer exists
	updated field no longer exists
ActivityStreams
	no issues
AppData
	no issues
Group
	no issues
Message
	type is a string, not an enumeration
Person
	some plural fields, such as accounts, addresses, appData are List<?>, while others are List<ListField>
	thumbnailUrl is a Url, inconsequent with other Urls like profileSong and profileVideo
	Missing mandatory properties:
		alternateNames
		connected
		contactPreference
		dn
		location
		nativeName
		preferredName
		published
		relationships
		updated
	Optional properties:
		anniversary is missing
		bodytype is a string, not an enumeration
		children is a Plural-Field<String>, not a string
		drinker is a string, not an enumeration
		gender is a string, not an enumeration
		lookingFor is a string, not a list of enumerations
		note is missing
		pets is a Plural-Field<String>, not a string
		orgIdentifier is missing
		politicalViews is a Plural-Field<String>, not a string
		smoker is a string, not an enumeration

Additional Social Data:

Account
	no issues
ActionLink 
	is completely missing
ActivityObject
	no issues
Address
	building is missing
	floor is missing
	primary field does not exist
Album
	no issues
AppId
	no issues
FieldMetadata
	is completely missing
GroupId
	no issues
MediaItem
	duration is an integer value, not a string
	file_size is a long value, not a string
	num_comments is an integer value, not a string
	num_views is an integer value, not a string
	num_votes is an integer value, not a string
	rating is an integer value, not a string
	tagged_people is a List<String>, not a string
	tags is a List<String>, not a string
	url is a string, which is inconsequent with the use of URLs in other entities
MediaLink
	url is a string, which is inconsequent with the use of URLs in other entities
Name
	additionalName does not exist
	middleName is missing
	pronunciation is missing
	pronunciationUrl is missing
ObjectMetadata
	is completely missing
Organization
	department is missing
	endDate could also be a string, not a date only
	location is missing
	primary field does not exist
File
	is completely missing
PropertyMetadata
	is completely missing


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472464#comment-13472464 ] 

Ryan Baxter commented on SHINDIG-1878:
--------------------------------------

In short yes, but we are trying to balance compliance with actually putting a release out there people can use.  It has been a while since we have done a release and I feel like people may be getting anxious.  I was thinking about working towards compliance in subsequent 2.5.x releases, but I do see your concern about introducing breaking changes in a point release.
                
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>         Attachments: SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "J.W. Janssen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

J.W. Janssen updated SHINDIG-1878:
----------------------------------

    Attachment: SHINDIG1878.patch

Finally had some time to finish the patch I promised...

This patch adds all missing mandatory fields from the primary and additional social data:

- Address;
- Name;
- Organization;
- Person.

                
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>             Fix For: 2.5.0, 2.5.0-beta6
>
>         Attachments: SHINDIG1878.patch, SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485364#comment-13485364 ] 

Henry Saputra commented on SHINDIG-1878:
----------------------------------------

Looks like this one wont make it to 2.5.0-beta5?
                
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>             Fix For: 2.5.0, 2.5.0-beta5
>
>         Attachments: SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "J.W. Janssen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472327#comment-13472327 ] 

J.W. Janssen commented on SHINDIG-1878:
---------------------------------------

I'm personally not keen on changing this in a 2.5.x release, as these changes will impact the backend services (and JPA mappings) of Shindig. This would make the .x release essentially a major release as it is no longer possible (at least: not easy) to downgrade.

                
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>         Attachments: SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "J.W. Janssen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507206#comment-13507206 ] 

J.W. Janssen commented on SHINDIG-1878:
---------------------------------------

There's no particular reason for this other that I was a bit lazy and used Eclipse to generate the patches (I had more pending changes to create patches for). Eclipse seems to create patches relative to its projects, which makes it hard to apply as single (uber-)patch... Both patches need to be applied to get the code compiling again.
                
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>             Fix For: 2.5.0, 2.5.0-beta6
>
>         Attachments: SHINDIG1878.patch, SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506705#comment-13506705 ] 

Henry Saputra commented on SHINDIG-1878:
----------------------------------------

Thanks for the patch. So what do the different reviews are for? Are they combined into the final fix for this issue?
 
                
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>             Fix For: 2.5.0, 2.5.0-beta6
>
>         Attachments: SHINDIG1878.patch, SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "J.W. Janssen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474200#comment-13474200 ] 

J.W. Janssen commented on SHINDIG-1878:
---------------------------------------

I'll try to provide a couple of patches for most of the trivial cases...
                
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>             Fix For: 2.5.0
>
>         Attachments: SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "J.W. Janssen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

J.W. Janssen updated SHINDIG-1878:
----------------------------------

    Description: 
Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.


  was:
Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out below.

Primary Social Data:

Activity
	entity is deprecated
	titleId field no longer exists
	updated field no longer exists
ActivityStreams
	no issues
AppData
	no issues
Group
	no issues
Message
	type is a string, not an enumeration
Person
	some plural fields, such as accounts, addresses, appData are List<?>, while others are List<ListField>
	thumbnailUrl is a Url, inconsequent with other Urls like profileSong and profileVideo
	Missing mandatory properties:
		alternateNames
		connected
		contactPreference
		dn
		location
		nativeName
		preferredName
		published
		relationships
		updated
	Optional properties:
		anniversary is missing
		bodytype is a string, not an enumeration
		children is a Plural-Field<String>, not a string
		drinker is a string, not an enumeration
		gender is a string, not an enumeration
		lookingFor is a string, not a list of enumerations
		note is missing
		pets is a Plural-Field<String>, not a string
		orgIdentifier is missing
		politicalViews is a Plural-Field<String>, not a string
		smoker is a string, not an enumeration

Additional Social Data:

Account
	no issues
ActionLink 
	is completely missing
ActivityObject
	no issues
Address
	building is missing
	floor is missing
	primary field does not exist
Album
	no issues
AppId
	no issues
FieldMetadata
	is completely missing
GroupId
	no issues
MediaItem
	duration is an integer value, not a string
	file_size is a long value, not a string
	num_comments is an integer value, not a string
	num_views is an integer value, not a string
	num_votes is an integer value, not a string
	rating is an integer value, not a string
	tagged_people is a List<String>, not a string
	tags is a List<String>, not a string
	url is a string, which is inconsequent with the use of URLs in other entities
MediaLink
	url is a string, which is inconsequent with the use of URLs in other entities
Name
	additionalName does not exist
	middleName is missing
	pronunciation is missing
	pronunciationUrl is missing
ObjectMetadata
	is completely missing
Organization
	department is missing
	endDate could also be a string, not a date only
	location is missing
	primary field does not exist
File
	is completely missing
PropertyMetadata
	is completely missing



moved original comments to a separate file as to keep formatting.
                
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>         Attachments: SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan Baxter updated SHINDIG-1878:
---------------------------------

    Fix Version/s: 2.5.0-beta5
    
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>             Fix For: 2.5.0, 2.5.0-beta5
>
>         Attachments: SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473204#comment-13473204 ] 

Ryan Baxter commented on SHINDIG-1878:
--------------------------------------

@Jan Willen I agree lets move this out to the dev list.

@Marcel Sounds cool I understand the need and desire to have this in 2.5.

Do either of you want to help with the implementation?
                
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>         Attachments: SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "J.W. Janssen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

J.W. Janssen updated SHINDIG-1878:
----------------------------------

    Attachment: SHINDIG1878.txt
    
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>         Attachments: SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan Baxter updated SHINDIG-1878:
---------------------------------

    Fix Version/s:     (was: 2.5.0-beta5)
                   2.5.0-beta6
    
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>             Fix For: 2.5.0, 2.5.0-beta6
>
>         Attachments: SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "J.W. Janssen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473170#comment-13473170 ] 

J.W. Janssen commented on SHINDIG-1878:
---------------------------------------

Wouldn't it be an idea to move this discussion to the ML to get other people's attention on this?

                
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>         Attachments: SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472307#comment-13472307 ] 

Ryan Baxter commented on SHINDIG-1878:
--------------------------------------

J.W. how important is it for your or your org that we get fixes for this in 2.5?  We are trying to close down 2.5 and seems like this might be a candidate for a 2.5.x release.
                
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>         Attachments: SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474216#comment-13474216 ] 

Ryan Baxter commented on SHINDIG-1878:
--------------------------------------

Great thanks!
                
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>             Fix For: 2.5.0
>
>         Attachments: SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "J.W. Janssen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472383#comment-13472383 ] 

J.W. Janssen commented on SHINDIG-1878:
---------------------------------------

Isn't Shindig 2.5 supposed to be OpenSocial 2.5 compliant? If so, then I think this issue should still be taken into consideration before making a final call on 2.5.0. 
                
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>         Attachments: SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473172#comment-13473172 ] 

Marcel Offermans commented on SHINDIG-1878:
-------------------------------------------

+1 for fixing this before the final 2.5.0 release, because point releases should not break APIs. I work for the same organisation as Jan Willem, and we are embedding Shindig in a modular, OSGi based environment (Amdatu, see http://www.amdatu.org/). For that we would like to implement the latest OS spec, and therefore would like to have stable APIs especially at those points where we want to offer people the freedom to "plug in" different implementations.
                
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>         Attachments: SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472366#comment-13472366 ] 

Ryan Baxter commented on SHINDIG-1878:
--------------------------------------

OK so you want to target this for 3.0 then?  If so can you set 3.0 as the fix version?
                
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>         Attachments: SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Comment Edited] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "J.W. Janssen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506399#comment-13506399 ] 

J.W. Janssen edited comment on SHINDIG-1878 at 11/29/12 11:17 AM:
------------------------------------------------------------------

Finally had some time to finish the patch I promised...

This patch adds all missing mandatory fields from the primary and additional social data:

- Address;
- Name;
- Organization;
- Person.

Made review requests: https://reviews.apache.org/r/8266/ and https://reviews.apache.org/r/8267/.
                
      was (Author: jajans):
    Finally had some time to finish the patch I promised...

This patch adds all missing mandatory fields from the primary and additional social data:

- Address;
- Name;
- Organization;
- Person.

                  
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>             Fix For: 2.5.0, 2.5.0-beta6
>
>         Attachments: SHINDIG1878.patch, SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1878) Discrepancy between OpenSocial spec 2.5 and Shindig

Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan Baxter updated SHINDIG-1878:
---------------------------------

    Fix Version/s: 2.5.0
    
> Discrepancy between OpenSocial spec 2.5 and Shindig 
> ----------------------------------------------------
>
>                 Key: SHINDIG-1878
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1878
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.5.0-beta4
>            Reporter: J.W. Janssen
>             Fix For: 2.5.0
>
>         Attachments: SHINDIG1878.txt
>
>
> Version 2.5 of OS is out. I've done a comparison between the data/model entities currently in code and the specification and found several discrepancies listed out in an attached file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira