You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by gs...@apache.org on 2007/07/27 17:44:56 UTC

svn commit: r560285 [2/2] - in /incubator/qpid/trunk/qpid: cpp/gentools/src/org/apache/qpid/gentools/ cpp/gentools/templ.cpp/ cpp/src/ cpp/src/qpid/broker/ cpp/src/qpid/client/ cpp/src/qpid/cluster/ cpp/src/qpid/framing/ cpp/src/tests/ python/ python/q...

Modified: incubator/qpid/trunk/qpid/python/tests_0-10/tx.py
URL: http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/python/tests_0-10/tx.py?view=diff&rev=560285&r1=560284&r2=560285
==============================================================================
--- incubator/qpid/trunk/qpid/python/tests_0-10/tx.py (original)
+++ incubator/qpid/trunk/qpid/python/tests_0-10/tx.py Fri Jul 27 08:44:52 2007
@@ -30,23 +30,39 @@
         """
         Test that commited publishes are delivered and commited acks are not re-delivered
         """
+        channel2 = self.client.channel(2)
+        channel2.channel_open()
+        self.perform_txn_work(channel2, "tx-commit-a", "tx-commit-b", "tx-commit-c")
+        channel2.tx_commit()
+        channel2.channel_close()
+
+        #use a different channel with new subscriptions to ensure
+        #there is no redelivery of acked messages:
         channel = self.channel
-        queue_a, queue_b, queue_c = self.perform_txn_work(channel, "tx-commit-a", "tx-commit-b", "tx-commit-c")
-        channel.tx_commit()
+        channel.tx_select()
+
+        channel.message_consume(queue="tx-commit-a", destination="qa", no_ack=False)
+        queue_a = self.client.queue("qa")
+
+        channel.message_consume(queue="tx-commit-b", destination="qb", no_ack=False)
+        queue_b = self.client.queue("qb")
+
+        channel.message_consume(queue="tx-commit-c", destination="qc", no_ack=False)
+        queue_c = self.client.queue("qc")
 
         #check results
         for i in range(1, 5):
             msg = queue_c.get(timeout=1)
             self.assertEqual("TxMessage %d" % i, msg.body)
-            msg.ok()
+            msg.complete()
 
         msg = queue_b.get(timeout=1)
         self.assertEqual("TxMessage 6", msg.body)
-        msg.ok()
+        msg.complete()
 
         msg = queue_a.get(timeout=1)
         self.assertEqual("TxMessage 7", msg.body)
-        msg.ok()
+        msg.complete()
 
         for q in [queue_a, queue_b, queue_c]:
             try:
@@ -76,15 +92,15 @@
         for i in range(1, 5):
             msg = queue_a.get(timeout=1)
             self.assertEqual("Message %d" % i, msg.body)
-            msg.ok()
+            msg.complete()
 
         msg = queue_b.get(timeout=1)
         self.assertEqual("Message 6", msg.body)
-        msg.ok()
+        msg.complete()
 
         msg = queue_c.get(timeout=1)
         self.assertEqual("Message 7", msg.body)
-        msg.ok()
+        msg.complete()
 
         for q in [queue_a, queue_b, queue_c]:
             try:
@@ -114,15 +130,15 @@
         for i in range(1, 5):
             msg = queue_a.get(timeout=1)
             self.assertEqual("Message %d" % i, msg.body)
-            msg.ok()
+            msg.complete()
 
         msg = queue_b.get(timeout=1)
         self.assertEqual("Message 6", msg.body)
-        msg.ok()
+        msg.complete()
 
         msg = queue_c.get(timeout=1)
         self.assertEqual("Message 7", msg.body)
-        msg.ok()
+        msg.complete()
 
         for q in [queue_a, queue_b, queue_c]:
             try:
@@ -150,10 +166,10 @@
         channel.queue_bind(queue=name_c, exchange="amq.topic", routing_key=topic)
 
         for i in range(1, 5):
-            channel.message_transfer(routing_key=name_a, body="Message %d" % i)
+            channel.message_transfer(routing_key=name_a, message_id="msg%d" % i, body="Message %d" % i)
 
-        channel.message_transfer(routing_key=key, destination="amq.direct", body="Message 6")
-        channel.message_transfer(routing_key=topic, destination="amq.topic", body="Message 7")
+        channel.message_transfer(routing_key=key, destination="amq.direct", message_id="msg6", body="Message 6")
+        channel.message_transfer(routing_key=topic, destination="amq.topic", message_id="msg7", body="Message 7")
 
         channel.tx_select()
 
@@ -164,25 +180,25 @@
             msg = queue_a.get(timeout=1)
             self.assertEqual("Message %d" % i, msg.body)
 
-        msg.ok(batchoffset=-3)
+        msg.complete()
 
         channel.message_consume(queue=name_b, destination="sub_b", no_ack=False)
         queue_b = self.client.queue("sub_b")
         msg = queue_b.get(timeout=1)
         self.assertEqual("Message 6", msg.body)
-        msg.ok()
+        msg.complete()
 
         sub_c = channel.message_consume(queue=name_c, destination="sub_c", no_ack=False)
         queue_c = self.client.queue("sub_c")
         msg = queue_c.get(timeout=1)
         self.assertEqual("Message 7", msg.body)
-        msg.ok()
+        msg.complete()
 
         #publish messages
         for i in range(1, 5):
-            channel.message_transfer(routing_key=topic, destination="amq.topic", body="TxMessage %d" % i)
+            channel.message_transfer(routing_key=topic, destination="amq.topic", message_id="tx-msg%d" % i, body="TxMessage %d" % i)
 
-        channel.message_transfer(routing_key=key, destination="amq.direct", body="TxMessage 6")
-        channel.message_transfer(routing_key=name_a, body="TxMessage 7")
+        channel.message_transfer(routing_key=key, destination="amq.direct", message_id="tx-msg6", body="TxMessage 6")
+        channel.message_transfer(routing_key=name_a, message_id="tx-msg7", body="TxMessage 7")
 
         return queue_a, queue_b, queue_c

Modified: incubator/qpid/trunk/qpid/specs/amqp-transitional.0-10.xml
URL: http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/specs/amqp-transitional.0-10.xml?view=diff&rev=560285&r1=560284&r2=560285
==============================================================================
--- incubator/qpid/trunk/qpid/specs/amqp-transitional.0-10.xml (original)
+++ incubator/qpid/trunk/qpid/specs/amqp-transitional.0-10.xml Fri Jul 27 08:44:52 2007
@@ -6184,13 +6184,6 @@
     <chassis name="server" implement="MUST" />
     <chassis name="client" implement="MUST" />
 
-    <!-- TRANSITIONAL: this is included as a temporary measure to allow easier evolution from 0-9 to 0-10 -->
-    <method name = "ok" index = "500" label = "old means of signalling completion">
-      <chassis name = "server" implement = "MUST" />
-      <chassis name = "client" implement = "MUST" />
-    </method>
-
-
     <!-- - Method: message.transfer  - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -->
 
     <method name="transfer" index="10" label="transfer a message">
@@ -6220,8 +6213,9 @@
       <chassis name="server" implement="MUST" />
       <chassis name="client" implement="MUST" />
 
-      <response name="ok" />
+      <!-- commented out to ease transition from 0-9 to 0-10
       <response name="reject" />
+      -->
 
       <field name="ticket" domain="access-ticket" label="access ticket">
         <rule name="validity" on-failure="access-refused">
@@ -6594,8 +6588,9 @@
 
       <chassis name="server" implement="MUST" />
 
-      <response name="ok" /><!-- added in just to ease transition -->
+      <!-- commented out to aid transition to 0-10
       <response name="empty" />
+      -->
 
       <field name="ticket" domain="access-ticket">
         <rule name="ticket-required" on-failure="access-refused">