You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2026/01/09 18:13:03 UTC
(tomcat) branch main updated: Rename method parameter to make usage clearer
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 6eba184802 Rename method parameter to make usage clearer
6eba184802 is described below
commit 6eba1848021b45209acd30b1af2f19bc3ef60461
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri Jan 9 18:12:56 2026 +0000
Rename method parameter to make usage clearer
---
.../org/apache/catalina/authenticator/AuthenticatorBase.java | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/java/org/apache/catalina/authenticator/AuthenticatorBase.java b/java/org/apache/catalina/authenticator/AuthenticatorBase.java
index 5fe03bd65e..23d34efd11 100644
--- a/java/org/apache/catalina/authenticator/AuthenticatorBase.java
+++ b/java/org/apache/catalina/authenticator/AuthenticatorBase.java
@@ -878,13 +878,15 @@ public abstract class AuthenticatorBase extends ValveBase implements Authenticat
* Check to see if the user has already been authenticated earlier in the processing chain or if there is enough
* information available to authenticate the user without requiring further user interaction.
*
- * @param request The current request
- * @param response The current response
- * @param useSSO Should information available from SSO be used to attempt to authenticate the current user?
+ * @param request The current request
+ * @param response The current response
+ * @param useSsoCachedUserAndPassword Should the user and password available from SSO be used to attempt to
+ * authenticate the current user?
*
* @return <code>true</code> if the user was authenticated via the cache, otherwise <code>false</code>
*/
- protected boolean checkForCachedAuthentication(Request request, HttpServletResponse response, boolean useSSO) {
+ protected boolean checkForCachedAuthentication(Request request, HttpServletResponse response,
+ boolean useSsoCachedUserAndPassword) {
// Has the user already been authenticated?
Principal principal = request.getUserPrincipal();
@@ -903,7 +905,7 @@ public abstract class AuthenticatorBase extends ValveBase implements Authenticat
}
// Is there an SSO session against which we can try to reauthenticate?
- if (useSSO && ssoId != null) {
+ if (useSsoCachedUserAndPassword && ssoId != null) {
if (log.isDebugEnabled()) {
log.debug(sm.getString("authenticator.check.sso", ssoId));
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org