[jira] [Work logged] (HIVE-25618) Stack trace is difficult to find when qtest fails during setup/teardown

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-25618?focusedWorklogId=666386&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-666386 ]

ASF GitHub Bot logged work on HIVE-25618:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Oct/21 15:54
            Start Date: 18/Oct/21 15:54
    Worklog Time Spent: 10m 
      Work Description: zabetak opened a new pull request #2726:
URL: https://github.com/apache/hive/pull/2726


   ### What changes were proposed in this pull request?
   Remove the try, catch, print, and fail pattern in CLI drivers letting the exception to propagate. 
   
   ### Why are the changes needed?
   1. It is easier to find the original stack trace causing the failure without looking into multiple places.
   2. It makes the code more readable.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Manual and existing tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 666386)
    Remaining Estimate: 0h
            Time Spent: 10m

> Stack trace is difficult to find when qtest fails during setup/teardown
> -----------------------------------------------------------------------
>
>                 Key: HIVE-25618
>                 URL: https://issues.apache.org/jira/browse/HIVE-25618
>             Project: Hive
>          Issue Type: Improvement
>          Components: Testing Infrastructure
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When a qtest fails while executing one of the setup/teardown methods of a CLI driver ([CliAdapter|https://github.com/apache/hive/blob/3e37ba473545a691f5f32c08fc4b62b49257cab4/itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliAdapter.java#L36] and its subclasses):
> {code:java}
>   public abstract void beforeClass() throws Exception;
>   public abstract void setUp();
>   public abstract void tearDown();
>   public abstract void shutdown() throws Exception;
> {code}
> the original stack trace leading to the failure cannot be found easily. 
> Maven console shows a stack trace which doesn't correspond to the actual exception causing the problem but another one which in most cases does not contain the original cause. 
> The original stack trace is not displayed in the maven console and it is not in the {{target/tmp/logs/hive.log}} either. At the moment it goes to {{target/surefire-reports/...-output.txt}}. 
> The developer needs to search in 2-3 places and navigate back and forth to the code in order to find what went wrong.
> Ideally the stack trace from the original exception should be printed directly in maven console. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)