[GitHub] [systemds] Baunsgaard commented on a diff in pull request #1721: [SYSTEMDS-3280] Docker Setup For HE

[GitBox <gi...@apache.org>]

Baunsgaard commented on code in PR #1721:
URL: https://github.com/apache/systemds/pull/1721#discussion_r1013306627


##########
docker/entrypoint.sh:
##########
@@ -22,6 +22,8 @@
 
 # A script to execute the tests inside the docker container.
 
+cd /github/workspace/src/main/cpp
+./build.sh

Review Comment:
   i do not like this, since it would mean we have to build our c++ part every test.
   
   do you know how much the overhead is?



##########
src/test/java/org/apache/sysds/test/functions/federated/paramserv/EncryptedFederatedParamservTest.java:
##########
@@ -73,7 +72,7 @@ public static Collection<Object[]> parameters() {
 				//{"TwoNN", 	5, 1000, 100, 1, 0.01, 	"BSP", "BATCH", "KEEP_DATA_ON_WORKER", 	"NONE",			"true",	"BALANCED",		200},
 				{"TwoNN",	2, 4, 1, 4, 0.01, 		"SBP", "BATCH", "KEEP_DATA_ON_WORKER", 	"BASELINE",		"false",	"IMBALANCED",	200},
 				{"TwoNN",	2, 4, 1, 4, 0.01, 		"SBP", "BATCH", "KEEP_DATA_ON_WORKER", 	"BASELINE",		"false",	"BALANCED",		200},
-				{"CNN",		2, 4, 1, 4, 0.01, 		"SBP", "EPOCH", "SHUFFLE",			 	"BASELINE",		"false",	"BALANCED",		200},
+				//{"CNN",		2, 4, 1, 4, 0.01, 		"SBP", "EPOCH", "SHUFFLE",			 	"BASELINE",		"false",	"BALANCED",		200},

Review Comment:
   i assume the CNN did not work?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org