You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Brian Federle <br...@citrix.com> on 2014/04/02 20:31:03 UTC

Re: Review Request 12228: static resource compression

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/#review39322
-----------------------------------------------------------


Lazlo, I just tested your changes and everything looks good to me.

- Brian Federle


On March 30, 2014, 8:08 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12228/
> -----------------------------------------------------------
> 
> (Updated March 30, 2014, 8:08 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle, Darren Shepherd, Jessica Wang, and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB.
> 
> This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching.
> 
> 
> Diffs
> -----
> 
>   client/WEB-INF/web.xml 1af38e1 
>   client/pom.xml d8dbde7 
>   server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
>   server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12228/diff/
> 
> 
> Testing
> -------
> 
> yes, tested with firefox and chrome
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>