[GitHub] [pulsar] tisonkun commented on a diff in pull request #14189: [Flaky-test] org.apache.pulsar.metadata.ZKSessionTest#testSessionLost

[GitBox <gi...@apache.org>]

tisonkun commented on code in PR #14189:
URL: https://github.com/apache/pulsar/pull/14189#discussion_r959057654


##########
pulsar-metadata/src/test/java/org/apache/pulsar/metadata/ZKSessionTest.java:
##########
@@ -87,6 +87,8 @@ public void testSessionLost() throws Exception {
         assertEquals(e, SessionEvent.SessionLost);
 
         zks.start();
+        boolean zkServerReady = zks.waitForServerUp(zks.getConnectionString(), 30_000);
+        assertTrue(zkServerReady);

Review Comment:
   These lines don't help because it's already included in `zks.start`.
   
   I suspect that it's the CI overwhelmed to be blamed that we can hardly setup a proper timeout.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org