You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/07/13 03:11:51 UTC

[GitHub] [skywalking-infra-e2e] chunriyeqiongsaigao commented on a diff in pull request #79: Support non-fail-fast execution of test cases

chunriyeqiongsaigao commented on code in PR #79:
URL: https://github.com/apache/skywalking-infra-e2e/pull/79#discussion_r919609875


##########
commands/verify/verify.go:
##########
@@ -101,8 +101,13 @@ func DoVerifyAccordingConfig() error {
 		return err
 	}
 
+	failFast := e2eConfig.Verify.Setting.FailFast
+
 	for idx, v := range e2eConfig.Verify.Cases {
 		if v.GetExpected() == "" {
+			if !failFast {
+				continue
+			}
 			return fmt.Errorf("the expected data file for case[%v] is not specified", idx)

Review Comment:
   Thanks for your advice ! 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org