You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Archana H <ar...@gmail.com> on 2016/05/11 08:29:22 UTC
Re: Review Request 47180: LENS-1038 : Streaming and other session
related tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47180/
-----------------------------------------------------------
(Updated May 11, 2016, 8:29 a.m.)
Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.
Changes
-------
review comment changes
Summary (updated)
-----------------
LENS-1038 : Streaming and other session related tests
Repository: lens
Description
-------
Streaming and other session related tests
Diffs (updated)
-----
lens-regression/src/main/java/org/apache/lens/regression/core/constants/DriverConfig.java da13715
lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java PRE-CREATION
lens-regression/src/test/java/org/apache/lens/regression/SessionTests.java PRE-CREATION
Diff: https://reviews.apache.org/r/47180/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.561s]
[INFO] Lens .............................................. SUCCESS [2.827s]
[INFO] Lens API .......................................... SUCCESS [19.983s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.356s]
[INFO] Lens Cube ......................................... SUCCESS [13:42.634s]
[INFO] Lens DB storage ................................... SUCCESS [16.138s]
[INFO] Lens Query Library ................................ SUCCESS [12.865s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:21.882s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [33.708s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [19.681s]
[INFO] Lens Server ....................................... SUCCESS [8:25.801s]
[INFO] Lens client ....................................... SUCCESS [1:28.082s]
[INFO] Lens CLI .......................................... SUCCESS [1:18.041s]
[INFO] Lens Examples ..................................... SUCCESS [8.313s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.614s]
[INFO] Lens Distribution ................................. SUCCESS [9.532s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:07.238s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.319s]
[INFO] Lens Regression ................................... SUCCESS [10.384s]
[INFO] Lens UI ........................................... SUCCESS [46.063s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:45.897s
[INFO] Finished at: Tue May 10 11:23:35 UTC 2016
[INFO] Final Memory: 197M/2756M
[INFO] ------------------------------------------------------------------------
Thanks,
Archana H
Re: Review Request 47180: LENS-1038 : Streaming and other session
related tests
Posted by Archana H <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47180/
-----------------------------------------------------------
(Updated May 12, 2016, 6:33 a.m.)
Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.
Changes
-------
review changes
Repository: lens
Description
-------
Streaming and other session related tests
Diffs (updated)
-----
lens-regression/src/main/java/org/apache/lens/regression/core/constants/DriverConfig.java da13715
lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java PRE-CREATION
lens-regression/src/test/java/org/apache/lens/regression/SessionTests.java PRE-CREATION
Diff: https://reviews.apache.org/r/47180/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.561s]
[INFO] Lens .............................................. SUCCESS [2.827s]
[INFO] Lens API .......................................... SUCCESS [19.983s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.356s]
[INFO] Lens Cube ......................................... SUCCESS [13:42.634s]
[INFO] Lens DB storage ................................... SUCCESS [16.138s]
[INFO] Lens Query Library ................................ SUCCESS [12.865s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:21.882s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [33.708s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [19.681s]
[INFO] Lens Server ....................................... SUCCESS [8:25.801s]
[INFO] Lens client ....................................... SUCCESS [1:28.082s]
[INFO] Lens CLI .......................................... SUCCESS [1:18.041s]
[INFO] Lens Examples ..................................... SUCCESS [8.313s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.614s]
[INFO] Lens Distribution ................................. SUCCESS [9.532s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:07.238s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.319s]
[INFO] Lens Regression ................................... SUCCESS [10.384s]
[INFO] Lens UI ........................................... SUCCESS [46.063s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:45.897s
[INFO] Finished at: Tue May 10 11:23:35 UTC 2016
[INFO] Final Memory: 197M/2756M
[INFO] ------------------------------------------------------------------------
Thanks,
Archana H
Re: Review Request 47180: LENS-1038 : Streaming and other session
related tests
Posted by Deepak Barr <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47180/#review132631
-----------------------------------------------------------
Ship it!
Ship It!
- Deepak Barr
On May 11, 2016, 8:29 a.m., Archana H wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47180/
> -----------------------------------------------------------
>
> (Updated May 11, 2016, 8:29 a.m.)
>
>
> Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Streaming and other session related tests
>
>
> Diffs
> -----
>
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/DriverConfig.java da13715
> lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java PRE-CREATION
> lens-regression/src/test/java/org/apache/lens/regression/SessionTests.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/47180/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.561s]
> [INFO] Lens .............................................. SUCCESS [2.827s]
> [INFO] Lens API .......................................... SUCCESS [19.983s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.356s]
> [INFO] Lens Cube ......................................... SUCCESS [13:42.634s]
> [INFO] Lens DB storage ................................... SUCCESS [16.138s]
> [INFO] Lens Query Library ................................ SUCCESS [12.865s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:21.882s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [33.708s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [19.681s]
> [INFO] Lens Server ....................................... SUCCESS [8:25.801s]
> [INFO] Lens client ....................................... SUCCESS [1:28.082s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.041s]
> [INFO] Lens Examples ..................................... SUCCESS [8.313s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.614s]
> [INFO] Lens Distribution ................................. SUCCESS [9.532s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:07.238s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.319s]
> [INFO] Lens Regression ................................... SUCCESS [10.384s]
> [INFO] Lens UI ........................................... SUCCESS [46.063s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:45.897s
> [INFO] Finished at: Tue May 10 11:23:35 UTC 2016
> [INFO] Final Memory: 197M/2756M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Archana H
>
>
Re: Review Request 47180: LENS-1038 : Streaming and other session
related tests
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47180/#review132661
-----------------------------------------------------------
Fix it, then Ship it!
lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java (line 116)
<https://reviews.apache.org/r/47180/#comment196936>
You might also receive EXECUTED as status in some cases if formatting takes time.
Should we wait till query becomes successful ?
lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java (line 121)
<https://reviews.apache.org/r/47180/#comment196937>
Should we check instead
assertTrue(queryRes instanceof PersistentQueryResult)
Same for line 166
- Puneet Gupta
On May 11, 2016, 8:29 a.m., Archana H wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47180/
> -----------------------------------------------------------
>
> (Updated May 11, 2016, 8:29 a.m.)
>
>
> Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Streaming and other session related tests
>
>
> Diffs
> -----
>
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/DriverConfig.java da13715
> lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java PRE-CREATION
> lens-regression/src/test/java/org/apache/lens/regression/SessionTests.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/47180/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.561s]
> [INFO] Lens .............................................. SUCCESS [2.827s]
> [INFO] Lens API .......................................... SUCCESS [19.983s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.356s]
> [INFO] Lens Cube ......................................... SUCCESS [13:42.634s]
> [INFO] Lens DB storage ................................... SUCCESS [16.138s]
> [INFO] Lens Query Library ................................ SUCCESS [12.865s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:21.882s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [33.708s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [19.681s]
> [INFO] Lens Server ....................................... SUCCESS [8:25.801s]
> [INFO] Lens client ....................................... SUCCESS [1:28.082s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.041s]
> [INFO] Lens Examples ..................................... SUCCESS [8.313s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.614s]
> [INFO] Lens Distribution ................................. SUCCESS [9.532s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:07.238s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.319s]
> [INFO] Lens Regression ................................... SUCCESS [10.384s]
> [INFO] Lens UI ........................................... SUCCESS [46.063s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:45.897s
> [INFO] Finished at: Tue May 10 11:23:35 UTC 2016
> [INFO] Final Memory: 197M/2756M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Archana H
>
>