You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/12/08 16:48:56 UTC
Review Request 64454: Fixed a typo in a gpu test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64454/
-----------------------------------------------------------
Review request for mesos and Benno Evers.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 5e40a940770cb45c9ac181b953a4e57e4b053445
Diff: https://reviews.apache.org/r/64454/diff/1/
Testing
-------
See https://reviews.apache.org/r/64456/
Thanks,
Alexander Rukletsov
Re: Review Request 64454: Fixed a typo in a gpu test.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64454/#review193262
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On Dec. 8, 2017, 4:48 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64454/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 4:48 p.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 5e40a940770cb45c9ac181b953a4e57e4b053445
>
>
> Diff: https://reviews.apache.org/r/64454/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/64456/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 64454: Fixed a typo in a gpu test.
Posted by Benno Evers <be...@mesosphere.com>.
> On Dec. 8, 2017, 4:56 p.m., Benno Evers wrote:
> > src/tests/containerizer/nvidia_gpu_isolator_tests.cpp
> > Line 268 (original), 268 (patched)
> > <https://reviews.apache.org/r/64454/diff/1/?file=1911666#file1911666line268>
> >
> > Since we're fixing this, actually only one of these should need the extra-long waiting time, probably the second although I don't completely remember at which point in the executor code path the image is fetched.
Dropping this issue because its covered in a later review in this chain.
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64454/#review193257
-----------------------------------------------------------
On Dec. 8, 2017, 4:48 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64454/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 4:48 p.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 5e40a940770cb45c9ac181b953a4e57e4b053445
>
>
> Diff: https://reviews.apache.org/r/64454/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/64456/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 64454: Fixed a typo in a gpu test.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64454/#review193257
-----------------------------------------------------------
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp
Line 268 (original), 268 (patched)
<https://reviews.apache.org/r/64454/#comment271802>
Since we're fixing this, actually only one of these should need the extra-long waiting time, probably the second although I don't completely remember at which point in the executor code path the image is fetched.
- Benno Evers
On Dec. 8, 2017, 4:48 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64454/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 4:48 p.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 5e40a940770cb45c9ac181b953a4e57e4b053445
>
>
> Diff: https://reviews.apache.org/r/64454/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/64456/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>