[GitHub] [spark] HeartSaVioR commented on issue #24071: [SPARK-27138][TESTS][KAFKA] Remove AdminUtils calls (fixes deprecation)

[GitBox <gi...@apache.org>]

HeartSaVioR commented on issue #24071: [SPARK-27138][TESTS][KAFKA] Remove AdminUtils calls (fixes deprecation)
URL: https://github.com/apache/spark/pull/24071#issuecomment-472263827
 
 
   I don't know whether it's possible to replace all the ZK related things, but I'm a kind of feel uncomfortable since we just replace some paths which leverages ZK and remain other things. I'd like to kindly ask to investigate whether we call fully replace things dealing with ZK directly, but that may be non-trivial so that would be completely OK if we only want to address a part of.
   
   LGTM given the tests in Kafka module passed. 
   
   Btw, just for recording, `kafka.zk.AdminZkClient` is direct successor of `AdminUtils`, so even if we observe something (including intermittent failure) after the patch, we can move to `kafka.zk.AdminZkClient` then.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org