[GitHub] [beam] damondouglas commented on a diff in pull request #24958: [Playground] Datastore namespace, Helm deployment, Ingress timeout, REDIS type fixes

["damondouglas (via GitHub)" <gi...@apache.org>]

damondouglas commented on code in PR #24958:
URL: https://github.com/apache/beam/pull/24958#discussion_r1088353872


##########
playground/terraform/infrastructure/variables.tf:
##########
@@ -94,12 +94,12 @@ variable "redis_name" {
 
 variable "redis_tier" {
   description = "Tier of Redis"
-  default     = "STANDARD_HA"

Review Comment:
   Why are we downgrading?



##########
playground/terraform/build.gradle.kts:
##########
@@ -392,13 +392,17 @@ tasks.register("takeConfig") {
    var ipaddrname = ""
    var d_tag = ""
    var dns_name = ""
+   var dstore_name = ""

Review Comment:
   Should we spell out the full `datastore_name`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org