[GitHub] [spark] Kimahriman commented on a diff in pull request #41317: [SPARK-43802][SQL] Fix codegen for unhex and unbase64 with failOnError=true

["Kimahriman (via GitHub)" <gi...@apache.org>]

Kimahriman commented on code in PR #41317:
URL: https://github.com/apache/spark/pull/41317#discussion_r1206819676


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala:
##########
@@ -615,6 +615,9 @@ class MathExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
     checkEvaluation(Unhex(Literal("GG")), null)
     checkEvaluation(Unhex(Literal("123")), Array[Byte](1, 35))
     checkEvaluation(Unhex(Literal("12345")), Array[Byte](1, 35, 69))
+
+    // failOnError
+    checkEvaluation(Unhex(Literal("12345"), true), Array[Byte](1, 35, 69))

Review Comment:
   Yes this is just a positive test case that evaluation still works with failOnError enabled. It looked like there were other tests (that you commented on below), checking the error occurs, but probably doesn't care that it falls back to eval during the process.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org