You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2016/09/20 07:28:22 UTC

[GitHub] incubator-carbondata pull request #176: [CARBONDATA-208] Add configuration e...

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/176#discussion_r79549615
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
    @@ -461,8 +459,15 @@ private Object getFilterPredicates(Configuration configuration) {
           FilterExpressionProcessor filterExpressionProcessor,
           AbsoluteTableIdentifier absoluteTableIdentifier, FilterResolverIntf resolver,
           String segmentId) throws IndexBuilderException, IOException {
    -
    -    QueryStatisticsRecorder recorder = new QueryStatisticsRecorder("");
    +    String queryStatisticsRecorderInstanceType = CarbonProperties.getInstance()
    --- End diff --
    
    can we move this creation logic to the factory class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---