You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by nkalmar <gi...@git.apache.org> on 2018/06/04 10:11:57 UTC

[GitHub] zookeeper issue #533: ZOOKEEPER-2989:IPv6 literal address causes problems fo...

Github user nkalmar commented on the issue:

    https://github.com/apache/zookeeper/pull/533
  
    I agree with @anmolnar in that the methods are a little robust and test multiple things. Whether it should be refactored whenever we touch a unit test, that's a tough question. 
    
    But I also agree with what @maoling  said about the inner class: generally, unit tests should not be separated when dealing with inner classes, as they only makes sense in the context of the outer class.
    
    Anyway, the change looks good to me! 


---