You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by GitBox <gi...@apache.org> on 2018/06/02 19:40:26 UTC

[GitHub] rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things

rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things
URL: https://github.com/apache/geronimo-jwt-auth/pull/2#discussion_r192568355
 
 

 ##########
 File path: geronimo-jwt-auth-impl/src/test/resources/tck.xml
 ##########
 @@ -40,8 +40,6 @@
       <class name="org.eclipse.microprofile.jwt.tck.container.jaxrs.ProviderInjectionTest" />
       <class name="org.eclipse.microprofile.jwt.tck.container.jaxrs.RolesAllowedTest" />
       <class name="org.eclipse.microprofile.jwt.tck.container.jaxrs.InvalidTokenTest" />
-      <class name="org.eclipse.microprofile.jwt.tck.container.jaxrs.PrimitiveInjectionTest" />
 
 Review comment:
   Tck regression?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Re: [GitHub] rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things

Posted by Jean-Louis MONTEIRO <je...@gmail.com>.
It has been removed from the 1.1 TCK so removed it as well so we know what
we are passing

Le samedi 2 juin 2018, GitBox <gi...@apache.org> a écrit :

> rmannibucau commented on a change in pull request #2: Upgrade to Eclipse
> Microprofile 1.1 and minor things
> URL: https://github.com/apache/geronimo-jwt-auth/pull/2#
> discussion_r192568355
>
>
>
>  ##########
>  File path: geronimo-jwt-auth-impl/src/test/resources/tck.xml
>  ##########
>  @@ -40,8 +40,6 @@
>        <class name="org.eclipse.microprofile.jwt.tck.container.jaxrs.ProviderInjectionTest"
> />
>        <class name="org.eclipse.microprofile.jwt.tck.container.jaxrs.RolesAllowedTest"
> />
>        <class name="org.eclipse.microprofile.jwt.tck.container.jaxrs.InvalidTokenTest"
> />
> -      <class name="org.eclipse.microprofile.jwt.tck.container.jaxrs.PrimitiveInjectionTest"
> />
>
>  Review comment:
>    Tck regression?
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> With regards,
> Apache Git Services
>


-- 
Jean-Louis