You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Duncan Jones (JIRA)" <ji...@apache.org> on 2012/09/16 22:45:08 UTC

[jira] [Commented] (LANG-795) Replace all "String encoding" parameters with Charset

    [ https://issues.apache.org/jira/browse/LANG-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456662#comment-13456662 ] 

Duncan Jones commented on LANG-795:
-----------------------------------

A cursory glance through the code base turned up only StringUtils.toString(byte[] bytes, String charsetName) as an offender. Do you know of others?
                
> Replace all "String encoding" parameters with Charset
> -----------------------------------------------------
>
>                 Key: LANG-795
>                 URL: https://issues.apache.org/jira/browse/LANG-795
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.*
>    Affects Versions: 3.1
>            Reporter: Aaron Digulla
>
> In several places, String constants are used to specify an encoding for data.
> Please add methods that accept {{Charset}} instead, and deprecate the existing methods.
> The goal of this change is to reduce code smell (using String constants instead of a real value type).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira