You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/22 12:24:26 UTC
[GitHub] [rocketmq] YangJodie commented on a diff in pull request #4752: [ISSUE #4749] make topic length , consumer group length configable
YangJodie commented on code in PR #4752:
URL: https://github.com/apache/rocketmq/pull/4752#discussion_r951373755
##########
client/src/main/java/org/apache/rocketmq/client/Validators.java:
##########
@@ -33,8 +33,12 @@
* Common Validator
*/
public class Validators {
- public static final int CHARACTER_MAX_LENGTH = 255;
- public static final int TOPIC_MAX_LENGTH = 127;
+ public static final int DEFAULT_TOPIC_MAX_LENGTH = 192;
+ public static final int DEFAULT_CONSUMER_GROUP_MAX_LENGTH = 255;
+ // not thread safe
+ public static int consumerGroupMaxLength = DEFAULT_CONSUMER_GROUP_MAX_LENGTH;
Review Comment:
If I actually set this length to 255, the retry topic may be limited by the system topic length. we need reduce the length to safe water.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org