You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/02/19 09:31:56 UTC

[GitHub] [tinkerpop] FlorianHockmann commented on issue #1247: TINKERPOP-2192 Null checks added to Connection.Parse

FlorianHockmann commented on issue #1247: TINKERPOP-2192 Null checks added to Connection.Parse
URL: https://github.com/apache/tinkerpop/pull/1247#issuecomment-588122540
 
 
   > Also at same time not sure if it hides bad JSON setting or other json related behind. Should we fail totally in this case?
   
   We would still get an error in that case [from here](https://github.com/apache/tinkerpop/blob/master/gremlin-dotnet/src/Gremlin.Net/Driver/Connection.cs#L136) where the `receivedMsg` is also accessed without a null check. If `receivedMsg` is `null` then `TryParseResponseMessage` will throw a `NullReferenceException` which will be caught by the try/catch in `Parse` and we notify the response handler about the exception.
   I think that we should however ensure that we're not getting an exception in a `catch` clause.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services