[GitHub] [jackrabbit-filevault] kwin commented on a change in pull request #204: JCRVLT-604 - RepositoryCopier doesn't allow Property Based Filtering

[GitBox <gi...@apache.org>]

kwin commented on a change in pull request #204:
URL: https://github.com/apache/jackrabbit-filevault/pull/204#discussion_r803430609



##########
File path: vault-core/src/main/java/org/apache/jackrabbit/vault/util/RepositoryCopier.java
##########
@@ -410,11 +410,17 @@ private void copy(AutoSave autoSave, Node src, Node dstParent, String dstName, b
                             currentSize+=s;
                         }
                     } else {
-                        Value v = p.getValue();
-                        dst.setProperty(pName, v);
-                        long s= p.getLength();
-                        totalSize+=s;
-                        currentSize+=s;
+                        // Filter out unwanted properties.  Remove them from the destination if they are excluded by filter

Review comment:
       The same logic would need to be applied to `sysCopy` which uses JCR System View to copy nodes from src to dst. This requires some more code changes as you probably need to implement a filtering ContentHandler (based on http://www.saxproject.org/apidoc/org/xml/sax/helpers/XMLFilterImpl.html).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org