[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #11141: [Fix-11140] Added resource parameters for function verification

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #11141:
URL: https://github.com/apache/dolphinscheduler/pull/11141#discussion_r930814906


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckService.java:
##########
@@ -51,7 +51,7 @@
      * @param logger
      * @return
      */
-    boolean operationPermissionCheck(Object authorizationType, Integer userId, String permissionKey, Logger logger);
+    boolean operationPermissionCheck(Object authorizationType, Object[] projectIds, Integer userId, String permissionKey, Logger logger);

Review Comment:
   I didn't see the whole code, but can we use a class to wrap the parameter, like `PermisionFactor` or anyother.
   I just worry once we need to modify the parameter in the future, we need to update all method execution.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org