You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "swamirishi (via GitHub)" <gi...@apache.org> on 2026/02/08 07:58:35 UTC
Re: [PR] HDDS-13311. Directory Deleting Service can use deleteRange for subDirectories and subFiles [ozone]
swamirishi commented on code in PR #9423:
URL: https://github.com/apache/ozone/pull/9423#discussion_r2778842469
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMDirectoriesPurgeResponseWithFSO.java:
##########
@@ -147,25 +148,27 @@ public void processPaths(
deletedSpaceOmMetadataManager.getDeletedDirTable().putWithBatch(deletedSpaceBatchOperation,
ozoneDeleteKey, keyInfo);
- keySpaceOmMetadataManager.getDirectoryTable().deleteWithBatch(keySpaceBatchOperation,
Review Comment:
@aryangupta1998 We should keep the individual deletes to keep the changes backward compatible since we can have a few transactions which could be unflushed in the followers this can lead to split brain. What I would suggest would be to create a new OmDirectoriesPurgeRangeRequest and Response which extends the old implementation and new proto request type enum to have new and old implementation in parallel. We should also have an OM server version bump for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org