You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2021/11/22 19:51:54 UTC

Review Request 73724: RANGER-3522: Improve Tagsync authentication error reporting

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73724/
-----------------------------------------------------------

Review request for ranger, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3522
    https://issues.apache.org/jira/browse/RANGER-3522


Repository: ranger


Description
-------

TagSync is expected to cause system exit if any kerberos authentication error is encountered. There might be situations where it starts without reporting any errors and hence no messages are processed. This needs to be investigated and fixed.

The errors in validating the kerberos principal and keytab path were being ignored. This patch corrects that.


Diffs
-----

  tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java c723b0f57 


Diff: https://reviews.apache.org/r/73724/diff/1/


Testing
-------

Ran all unit tests successfully.


Thanks,

Abhay Kulkarni


Re: Review Request 73724: RANGER-3522: Improve Tagsync authentication error reporting

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73724/#review223762
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On Nov. 22, 2021, 7:51 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73724/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2021, 7:51 p.m.)
> 
> 
> Review request for ranger, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3522
>     https://issues.apache.org/jira/browse/RANGER-3522
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> TagSync is expected to cause system exit if any kerberos authentication error is encountered. There might be situations where it starts without reporting any errors and hence no messages are processed. This needs to be investigated and fixed.
> 
> The errors in validating the kerberos principal and keytab path were being ignored. This patch corrects that.
> 
> 
> Diffs
> -----
> 
>   tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java c723b0f57 
> 
> 
> Diff: https://reviews.apache.org/r/73724/diff/1/
> 
> 
> Testing
> -------
> 
> Ran all unit tests successfully.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Re: Review Request 73724: RANGER-3522: Improve Tagsync authentication error reporting

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73724/#review223764
-----------------------------------------------------------


Ship it!




Ship It!

- Pradeep Agrawal


On Nov. 22, 2021, 7:51 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73724/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2021, 7:51 p.m.)
> 
> 
> Review request for ranger, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3522
>     https://issues.apache.org/jira/browse/RANGER-3522
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> TagSync is expected to cause system exit if any kerberos authentication error is encountered. There might be situations where it starts without reporting any errors and hence no messages are processed. This needs to be investigated and fixed.
> 
> The errors in validating the kerberos principal and keytab path were being ignored. This patch corrects that.
> 
> 
> Diffs
> -----
> 
>   tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java c723b0f57 
> 
> 
> Diff: https://reviews.apache.org/r/73724/diff/1/
> 
> 
> Testing
> -------
> 
> Ran all unit tests successfully.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>