[GitHub] [flink-table-store] zjureel commented on a diff in pull request #302: [FLINK-29385] Verify duplicate column names for AddColumn

[GitBox <gi...@apache.org>]

zjureel commented on code in PR #302:
URL: https://github.com/apache/flink-table-store/pull/302#discussion_r977248865


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaManager.java:
##########
@@ -173,6 +174,15 @@ public TableSchema commitChanges(List<SchemaChange> changes) throws Exception {
                     newOptions.remove(removeOption.key());
                 } else if (change instanceof AddColumn) {
                     AddColumn addColumn = (AddColumn) change;
+                    Set<String> fieldNames =

Review Comment:
   > Why not directly filter the field name of add column in the stream of `newFields`?
   
   It's an interesting question. Maybe that the data types of these two columns are different, so i think it's better to return the error message to the user



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org