[GitHub] [kafka] C0urante commented on a diff in pull request #13386: Fix logging conditional

["C0urante (via GitHub)" <gi...@apache.org>]

C0urante commented on code in PR #13386:
URL: https://github.com/apache/kafka/pull/13386#discussion_r1135813644


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java:
##########
@@ -216,7 +216,7 @@ public boolean commitOffsets() {
             this.committableOffsets = CommittableOffsets.EMPTY;
         }
 
-        if (committableOffsets.isEmpty()) {
+        if (offsetsToCommit.isEmpty()) {

Review Comment:
   Don't we need to update the logging in the `else` branch to use `offsetsToCommit` instead of `committableOffsets` as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org