You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "auvipy (via GitHub)" <gi...@apache.org> on 2023/03/11 01:50:37 UTC
[GitHub] [airflow] auvipy opened a new pull request, #30033: Remove upper bound limit of astroid
auvipy opened a new pull request, #30033:
URL: https://github.com/apache/airflow/pull/30033
The issue was fixed & released so removing the upper bound
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vchiapaikeo commented on pull request #30033: Remove upper bound limit of astroid
Posted by "vchiapaikeo (via GitHub)" <gi...@apache.org>.
vchiapaikeo commented on PR #30033:
URL: https://github.com/apache/airflow/pull/30033#issuecomment-1465072033
Seeing this issue when trying to start breeze on latest w/ `breeze --python 3.9 --backend postgres start-airflow'`:
```
#0 6.661 ERROR: Cannot install apache-airflow[devel-ci]==2.6.0.dev0 because these package versions have conflicting dependencies.
#0 6.662
#0 6.662 The conflict is caused by:
#0 6.662 apache-airflow[devel-ci] 2.6.0.dev0 depends on astroid>=2.12.3
#0 6.662 The user requested (constraint) astroid==2.11.7
#0 6.662
#0 6.662 To fix this you could try to:
#0 6.662 1. loosen the range of package versions you've specified
#0 6.662 2. remove package versions to allow pip attempt to solve the dependency conflict
#0 6.662
#0 6.662 ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
------
ERROR: failed to solve: executor failed running [/bin/bash -o pipefail -o errexit -o nounset -o nolog -c bash /scripts/docker/install_airflow.sh]: exit code: 1
Your image build failed. It could be caused by conflicting dependencies.
Run `breeze ci-image build --upgrade-to-newer-dependencies` to upgrade them.
Creating network "docker-compose_default" with the default driver
Pulling airflow (ghcr.io/apache/airflow/main/ci/python3.9:latest)...
latest: Pulling from apache/airflow/main/ci/python3.9
```
Do constraints for the devel-ci extra need to be updated somehow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #30033: Remove upper bound limit of astroid
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #30033:
URL: https://github.com/apache/airflow/pull/30033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #30033: Remove upper bound limit of astroid
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #30033:
URL: https://github.com/apache/airflow/pull/30033#discussion_r1133008756
##########
setup.py:
##########
@@ -248,9 +248,7 @@ def write_version(filename: str = str(AIRFLOW_SOURCES_ROOT / "airflow" / "git_ve
"requests>=2.26.0",
]
doc = [
- # Astroid 2.12.* breaks documentation building
- # We can remove the limit here after https://github.com/PyCQA/astroid/issues/1708 is solved
- "astroid<2.12.0",
+ "astroid",
Review Comment:
```suggestion
"astroid>=2.12.3",
```
Don't we need to bump to the version that contains the fix?
or at least skip the ones known to have the issue: `!=2.12.0, !=2.12.1, !=2.12.2` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] auvipy commented on a diff in pull request #30033: Remove upper bound limit of astroid
Posted by "auvipy (via GitHub)" <gi...@apache.org>.
auvipy commented on code in PR #30033:
URL: https://github.com/apache/airflow/pull/30033#discussion_r1133009295
##########
setup.py:
##########
@@ -248,9 +248,7 @@ def write_version(filename: str = str(AIRFLOW_SOURCES_ROOT / "airflow" / "git_ve
"requests>=2.26.0",
]
doc = [
- # Astroid 2.12.* breaks documentation building
- # We can remove the limit here after https://github.com/PyCQA/astroid/issues/1708 is solved
- "astroid<2.12.0",
+ "astroid",
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] auvipy commented on pull request #30033: Remove upper bound limit of astroid
Posted by "auvipy (via GitHub)" <gi...@apache.org>.
auvipy commented on PR #30033:
URL: https://github.com/apache/airflow/pull/30033#issuecomment-1464861208
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30033: Remove upper bound limit of astroid
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30033:
URL: https://github.com/apache/airflow/pull/30033#issuecomment-1464997115
Thank you !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30033: Remove upper bound limit of astroid
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30033:
URL: https://github.com/apache/airflow/pull/30033#issuecomment-1465074615
Yes. They should update itself automatically (but it can a little time depending on the success of main build.
As a temp solution you should follow the advice given (if you look closely:
> Your image build failed. It could be caused by conflicting dependencies.
> Run `breeze ci-image build --upgrade-to-newer-dependencies` to upgrade them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30033: Remove upper bound limit of astroid
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30033:
URL: https://github.com/apache/airflow/pull/30033#issuecomment-1465080530
Yep. The constraints with updated astroid have just been pushed after main success: https://github.com/apache/airflow/commit/69b9d24d93a8fca00cd39e2b16b2c97ed26b0e86
So it should work now without need to add the flag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org