You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ranger.apache.org by ab...@apache.org on 2018/03/06 23:55:38 UTC

ranger git commit: RANGER-2000: Fix unit tests

Repository: ranger
Updated Branches:
  refs/heads/master a9fbbcafa -> 1d4afbe57


RANGER-2000: Fix unit tests


Project: http://git-wip-us.apache.org/repos/asf/ranger/repo
Commit: http://git-wip-us.apache.org/repos/asf/ranger/commit/1d4afbe5
Tree: http://git-wip-us.apache.org/repos/asf/ranger/tree/1d4afbe5
Diff: http://git-wip-us.apache.org/repos/asf/ranger/diff/1d4afbe5

Branch: refs/heads/master
Commit: 1d4afbe57a86bf025b00b0e2c93793d355a9096d
Parents: a9fbbca
Author: Abhay Kulkarni <ak...@hortonworks.com>
Authored: Tue Mar 6 15:33:29 2018 -0800
Committer: Abhay Kulkarni <ak...@hortonworks.com>
Committed: Tue Mar 6 15:33:29 2018 -0800

----------------------------------------------------------------------
 .../plugin/policyengine/TestPolicyEngine.java    | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ranger/blob/1d4afbe5/agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
----------------------------------------------------------------------
diff --git a/agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java b/agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
index 97ae8a2..325626a 100644
--- a/agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
+++ b/agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
@@ -61,6 +61,7 @@ import java.util.List;
 import java.util.Map;
 import java.util.Properties;
 import java.util.Set;
+import java.util.TimeZone;
 
 import static org.junit.Assert.*;
 
@@ -312,7 +313,12 @@ public class TestPolicyEngine {
 	public void testPolicyEngine_temporary() {
 		String[] resourceFiles = {"/policyengine/test_policyengine_temporary.json"};
 
+		TimeZone defaultTZ = TimeZone.getDefault();
+		TimeZone.setDefault(TimeZone.getTimeZone("PST"));
+
 		runTestsFromResourceFiles(resourceFiles);
+
+		TimeZone.setDefault(defaultTZ);
 	}
 
 	@Test
@@ -533,35 +539,39 @@ public class TestPolicyEngine {
     }
 
     @Test
-    public void testValiditySchedularInvalid() {
+    public void testValiditySchedulerInvalid() {
         String resourceName = "/policyengine/validityscheduler/test-validity-schedules-invalid.json";
 
         runValiditySchedulerTests(resourceName);
     }
 
     @Test
-    public void testValiditySchedularValid() {
+    public void testValiditySchedulerValid() {
         String resourceName = "/policyengine/validityscheduler/test-validity-schedules-valid.json";
 
         runValiditySchedulerTests(resourceName);
     }
 
     @Test
-    public void testValiditySchedularApplicable() {
+    public void testValiditySchedulerApplicable() {
         String resourceName = "/policyengine/validityscheduler/test-validity-schedules-valid-and-applicable.json";
 
         runValiditySchedulerTests(resourceName);
     }
 
     private void runValiditySchedulerTests(String resourceName) {
+        TimeZone defaultTZ = TimeZone.getDefault();
+        TimeZone.setDefault(TimeZone.getTimeZone("PST"));
+
         List<ValiditySchedulerTestCase> testCases = null;
+
         InputStream inStream = this.getClass().getResourceAsStream(resourceName);
         InputStreamReader reader   = new InputStreamReader(inStream);
         try {
             Type listType = new TypeToken<List<ValiditySchedulerTestCase>>() {}.getType();
             testCases = gsonBuilder.fromJson(reader, listType);
         } catch (Exception e) {
-	        assertFalse("Exception in reading validity-scheduler test cases.", true);
+            assertFalse("Exception in reading validity-scheduler test cases.", true);
         }
 
         assertNotNull("TestCases are null!", testCases);
@@ -597,6 +607,7 @@ public class TestPolicyEngine {
                 assertTrue(testCase.name + ", [" + validationFailures +"]", validationFailures.size() == testCase.result.validationFailureCount);
             }
         }
+        TimeZone.setDefault(defaultTZ);
     }
 
     static class RangerAccessRequestDeserializer implements JsonDeserializer<RangerAccessRequest> {