You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/10 10:30:52 UTC

[GitHub] [airflow] dstandish commented on a diff in pull request #28161: AIP-51 - Executor Coupling in Logging

dstandish commented on code in PR #28161:
URL: https://github.com/apache/airflow/pull/28161#discussion_r1065603602


##########
airflow/executors/kubernetes_executor.py:
##########
@@ -749,6 +751,57 @@ def _change_state(self, key: TaskInstanceKey, state: str | None, pod_id: str, na
                 self.log.debug("Could not find key: %s", str(key))
         self.event_buffer[key] = state, None
 
+    @staticmethod
+    def _get_pod_namespace(ti: TaskInstance):
+        pod_override = ti.executor_config.get("pod_override")
+        namespace = None
+        with suppress(Exception):

Review Comment:
   It's just a simpler way to do this https://github.com/apache/airflow/pull/28546/files#diff-e7f34f73940eb52d92bb991abedc1c963431c5373c12dff739c8fb7d03e93d3aL195



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org