You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by PRAGYA MITTAL <mi...@gmail.com> on 2014/09/03 11:56:25 UTC
Review Request 25294: Patch for late data regression test for feed and
process
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25294/
-----------------------------------------------------------
Review request for Falcon.
Repository: falcon-git
Description
-------
Late data regression test for feed and process
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java PRE-CREATION
falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/process-agg.xml 09e8a09
Diff: https://reviews.apache.org/r/25294/diff/
Testing
-------
Thanks,
PRAGYA MITTAL
Re: Review Request 25294: Patch for late data regression test for
feed and process
Posted by PRAGYA MITTAL <mi...@gmail.com>.
> On Sept. 3, 2014, 10:03 a.m., samarth gupta wrote:
> >
Will make the required changes and upload the new patch
- PRAGYA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25294/#review52152
-----------------------------------------------------------
On Sept. 3, 2014, 9:56 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25294/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2014, 9:56 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Late data regression test for feed and process
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/process-agg.xml 09e8a09
>
> Diff: https://reviews.apache.org/r/25294/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 25294: Patch for late data regression test for
feed and process
Posted by samarth gupta <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25294/#review52152
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
<https://reviews.apache.org/r/25294/#comment90900>
make the comment as feed late data test
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
<https://reviews.apache.org/r/25294/#comment90901>
rename the bundle and method as lateData
- samarth gupta
On Sept. 3, 2014, 9:56 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25294/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2014, 9:56 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Late data regression test for feed and process
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/process-agg.xml 09e8a09
>
> Diff: https://reviews.apache.org/r/25294/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 25294: Patch for late data regression test for
feed and process
Posted by PRAGYA MITTAL <mi...@gmail.com>.
> On Sept. 3, 2014, 10:10 a.m., samarth gupta wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java, line 166
> > <https://reviews.apache.org/r/25294/diff/1/?file=675065#file675065line166>
> >
> > it this check really needed ... i think checking the run ID should be good enough
This is just an extra check, to ensure that process actually succeeded with no failures. Although testing for run Id will suffice. Will remove it as i see it is not required.
- PRAGYA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25294/#review52153
-----------------------------------------------------------
On Sept. 3, 2014, 9:56 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25294/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2014, 9:56 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Late data regression test for feed and process
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/process-agg.xml 09e8a09
>
> Diff: https://reviews.apache.org/r/25294/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 25294: Patch for late data regression test for
feed and process
Posted by PRAGYA MITTAL <mi...@gmail.com>.
> On Sept. 3, 2014, 10:10 a.m., samarth gupta wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java, line 180
> > <https://reviews.apache.org/r/25294/diff/1/?file=675065#file675065line180>
> >
> > it is better if we add this to oozieUtil and make it generic for both feed and process
It is already generic. Just need to move the function to OozieUtil. Will do it.
- PRAGYA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25294/#review52153
-----------------------------------------------------------
On Sept. 3, 2014, 9:56 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25294/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2014, 9:56 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Late data regression test for feed and process
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/process-agg.xml 09e8a09
>
> Diff: https://reviews.apache.org/r/25294/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 25294: Patch for late data regression test for
feed and process
Posted by PRAGYA MITTAL <mi...@gmail.com>.
> On Sept. 3, 2014, 10:10 a.m., samarth gupta wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java, line 101
> > <https://reviews.apache.org/r/25294/diff/1/?file=675065#file675065line101>
> >
> > use the method getInputFeed
Since the bundle used for testing has only one feed definition, so i need not use this function. Let me know if there are any other thoughts on the same.
- PRAGYA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25294/#review52153
-----------------------------------------------------------
On Sept. 3, 2014, 9:56 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25294/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2014, 9:56 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Late data regression test for feed and process
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/process-agg.xml 09e8a09
>
> Diff: https://reviews.apache.org/r/25294/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 25294: Patch for late data regression test for
feed and process
Posted by samarth gupta <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25294/#review52153
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
<https://reviews.apache.org/r/25294/#comment90902>
use the method getInputFeed
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
<https://reviews.apache.org/r/25294/#comment90903>
in place of uploading the data cant we use .... createMissingDependencies from oozie utils ?
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
<https://reviews.apache.org/r/25294/#comment90904>
it this check really needed ... i think checking the run ID should be good enough
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
<https://reviews.apache.org/r/25294/#comment90905>
it is better if we add this to oozieUtil and make it generic for both feed and process
- samarth gupta
On Sept. 3, 2014, 9:56 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25294/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2014, 9:56 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Late data regression test for feed and process
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/process-agg.xml 09e8a09
>
> Diff: https://reviews.apache.org/r/25294/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 25294: Patch for late data regression test for
feed and process
Posted by PRAGYA MITTAL <mi...@gmail.com>.
> On Sept. 3, 2014, 10:20 a.m., samarth gupta wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java, line 277
> > <https://reviews.apache.org/r/25294/diff/1/?file=675066#file675066line277>
> >
> > wait for instance to SUCCEED before creating new data
Here I am adding data to empty folders (created during missing dependencies) so that it can be processed before testing for late rerun. So instances will be in waiting state and hence can't be tested for going into succeeding state. Altrhough I have added wait for instance to SUCCEED constraint before adding data for late rerun.
- PRAGYA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25294/#review52155
-----------------------------------------------------------
On Sept. 3, 2014, 9:56 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25294/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2014, 9:56 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Late data regression test for feed and process
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/process-agg.xml 09e8a09
>
> Diff: https://reviews.apache.org/r/25294/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 25294: Patch for late data regression test for
feed and process
Posted by samarth gupta <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25294/#review52155
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java
<https://reviews.apache.org/r/25294/#comment90908>
method wait till instance are created can be used here.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java
<https://reviews.apache.org/r/25294/#comment90909>
logger.info can be repaced by logger.debug in all the test
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java
<https://reviews.apache.org/r/25294/#comment90910>
wait for instance to SUCCEED before creating new data
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java
<https://reviews.apache.org/r/25294/#comment90911>
combine the method from feedLate test and move both to oozieUtil
- samarth gupta
On Sept. 3, 2014, 9:56 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25294/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2014, 9:56 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Late data regression test for feed and process
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/process-agg.xml 09e8a09
>
> Diff: https://reviews.apache.org/r/25294/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 25294: Patch for late data regression test for
feed and process
Posted by samarth gupta <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25294/#review54243
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java
<https://reviews.apache.org/r/25294/#comment94251>
have a common OozieClient variable at start of method in place of calling "helper.getClusterHelper().getOozieClient()" every time.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
<https://reviews.apache.org/r/25294/#comment94252>
log statement can be removed. I think we already print entity definition before submit and schedule.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
<https://reviews.apache.org/r/25294/#comment94253>
Util.readEntityName(feed); is called multiple times in same test. Name value can be save in a variable and used at other places instead of calling funtion every time.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
<https://reviews.apache.org/r/25294/#comment94262>
why are we doing source.substring(26) ?
- samarth gupta
On Sept. 18, 2014, 12:47 p.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25294/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2014, 12:47 p.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Late data regression test for feed and process
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 922c030
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java 806bbd3
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 197c3c6
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java 7a5a91e
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java 378cbbd
> falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/InputFeed.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/cluster-0.1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/LocalDC_feedReplicaltion_BillingRC/FETL-BillingRC.xml eb31839
> falcon-regression/merlin/src/test/resources/LocalDC_feedReplicaltion_BillingRC/cluster-0.1.xml afa86c4
>
> Diff: https://reviews.apache.org/r/25294/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Added new patch
> https://reviews.apache.org/media/uploaded/files/2014/09/05/40eb0679-7e78-44f0-a023-523ca7cc45cc__FALCON-631-v2.patch
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 25294: Patch for late data regression test for
feed and process
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25294/
-----------------------------------------------------------
(Updated Dec. 18, 2014, 8:50 a.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
Late data regression test for feed and process
Diffs
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 922c030
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java 806bbd3
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExp_FutureAndLatestTest.java 25e2dfe
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 197c3c6
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java 7a5a91e
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java 378cbbd
falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/InputFeed.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/cluster-0.1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/LocalDC_feedReplicaltion_BillingRC/FETL-BillingRC.xml eb31839
falcon-regression/merlin/src/test/resources/LocalDC_feedReplicaltion_BillingRC/cluster-0.1.xml afa86c4
Diff: https://reviews.apache.org/r/25294/diff/
Testing
-------
File Attachments
----------------
Added new patch
https://reviews.apache.org/media/uploaded/files/2014/09/05/40eb0679-7e78-44f0-a023-523ca7cc45cc__FALCON-631-v2.patch
Thanks,
PRAGYA MITTAL
Re: Review Request 25294: Patch for late data regression test for
feed and process
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25294/
-----------------------------------------------------------
(Updated Dec. 18, 2014, 8:49 a.m.)
Review request for Falcon.
Bugs: FALCON-951
https://issues.apache.org/jira/browse/FALCON-951
Repository: falcon-git
Description
-------
Late data regression test for feed and process
Diffs
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 922c030
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java 806bbd3
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExp_FutureAndLatestTest.java 25e2dfe
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 197c3c6
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java 7a5a91e
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java 378cbbd
falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/InputFeed.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/cluster-0.1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/LocalDC_feedReplicaltion_BillingRC/FETL-BillingRC.xml eb31839
falcon-regression/merlin/src/test/resources/LocalDC_feedReplicaltion_BillingRC/cluster-0.1.xml afa86c4
Diff: https://reviews.apache.org/r/25294/diff/
Testing
-------
File Attachments
----------------
Added new patch
https://reviews.apache.org/media/uploaded/files/2014/09/05/40eb0679-7e78-44f0-a023-523ca7cc45cc__FALCON-631-v2.patch
Thanks,
PRAGYA MITTAL
Re: Review Request 25294: Patch for late data regression test for
feed and process
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25294/
-----------------------------------------------------------
(Updated Oct. 8, 2014, 10:02 a.m.)
Review request for Falcon.
Changes
-------
Handling checkstyle errors
Repository: falcon-git
Description
-------
Late data regression test for feed and process
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 922c030
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java 806bbd3
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExp_FutureAndLatestTest.java 25e2dfe
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 197c3c6
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java 7a5a91e
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java 378cbbd
falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/InputFeed.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/cluster-0.1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/LocalDC_feedReplicaltion_BillingRC/FETL-BillingRC.xml eb31839
falcon-regression/merlin/src/test/resources/LocalDC_feedReplicaltion_BillingRC/cluster-0.1.xml afa86c4
Diff: https://reviews.apache.org/r/25294/diff/
Testing
-------
File Attachments
----------------
Added new patch
https://reviews.apache.org/media/uploaded/files/2014/09/05/40eb0679-7e78-44f0-a023-523ca7cc45cc__FALCON-631-v2.patch
Thanks,
PRAGYA MITTAL
Re: Review Request 25294: Patch for late data regression test for
feed and process
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25294/
-----------------------------------------------------------
(Updated Oct. 7, 2014, 8:44 a.m.)
Review request for Falcon.
Changes
-------
Added required changes
Repository: falcon-git
Description
-------
Late data regression test for feed and process
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 922c030
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java 806bbd3
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 197c3c6
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java 7a5a91e
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java 378cbbd
falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/InputFeed.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/cluster-0.1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/LocalDC_feedReplicaltion_BillingRC/FETL-BillingRC.xml eb31839
falcon-regression/merlin/src/test/resources/LocalDC_feedReplicaltion_BillingRC/cluster-0.1.xml afa86c4
Diff: https://reviews.apache.org/r/25294/diff/
Testing
-------
File Attachments
----------------
Added new patch
https://reviews.apache.org/media/uploaded/files/2014/09/05/40eb0679-7e78-44f0-a023-523ca7cc45cc__FALCON-631-v2.patch
Thanks,
PRAGYA MITTAL
Re: Review Request 25294: Patch for late data regression test for
feed and process
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25294/
-----------------------------------------------------------
(Updated Sept. 18, 2014, 12:47 p.m.)
Review request for Falcon.
Changes
-------
Added changes according to last review
Repository: falcon-git
Description
-------
Late data regression test for feed and process
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 922c030
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java 806bbd3
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 197c3c6
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java 7a5a91e
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java 378cbbd
falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/InputFeed.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/cluster-0.1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/LocalDC_feedReplicaltion_BillingRC/FETL-BillingRC.xml eb31839
falcon-regression/merlin/src/test/resources/LocalDC_feedReplicaltion_BillingRC/cluster-0.1.xml afa86c4
Diff: https://reviews.apache.org/r/25294/diff/
Testing
-------
File Attachments
----------------
Added new patch
https://reviews.apache.org/media/uploaded/files/2014/09/05/40eb0679-7e78-44f0-a023-523ca7cc45cc__FALCON-631-v2.patch
Thanks,
PRAGYA MITTAL
Re: Review Request 25294: Patch for late data regression test for
feed and process
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25294/
-----------------------------------------------------------
(Updated Sept. 5, 2014, 5:31 a.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
Late data regression test for feed and process
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java PRE-CREATION
falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/process-agg.xml 09e8a09
Diff: https://reviews.apache.org/r/25294/diff/
Testing
-------
File Attachments (updated)
----------------
Added new patch
https://reviews.apache.org/media/uploaded/files/2014/09/05/40eb0679-7e78-44f0-a023-523ca7cc45cc__FALCON-631-v2.patch
Thanks,
PRAGYA MITTAL