You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/11/08 15:37:03 UTC

[GitHub] brooklyn-server pull request #416: Refactor and add to DSL tests

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/416

    Refactor and add to DSL tests

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server refactor/dsl-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/416.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #416
    
----
commit a5b34a722aa40bd74e0c5dbdf0c078689a2cd853
Author: Aled Sage <al...@gmail.com>
Date:   2016-11-08T15:29:28Z

    Code tidy for tests

commit 5399a3b86005a76e6d5702a5dc02abca0202930f
Author: Aled Sage <al...@gmail.com>
Date:   2016-11-08T15:32:06Z

    Add more DSL tests

commit cfd41f39d301973717034d6884119216f24bc618
Author: Aled Sage <al...@gmail.com>
Date:   2016-11-08T15:33:36Z

    Adds TestHttpCallYamlTest

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #416: Refactor and add to DSL tests

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/416
  
    Thanks @googlielmo - I think the previous jenkins failure was because an assertion timeout of one second failed. I've increased the timeout to use `Asserts.DEFAULT_LONG_TIMEOUT`. The apache jenkins box sometimes does starve the thread for a short (!) period of time, which can be greater than one second. For example, this could be during a full GC or due to contention on the build server.
    
    If jenkins passes this time, I'll merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #416: Refactor and add to DSL tests

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/416#discussion_r87014553
  
    --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/DslAndRebindYamlTest.java ---
    @@ -61,58 +56,41 @@
     
     import com.google.common.collect.Iterables;
     import com.google.common.collect.Lists;
    -import com.google.common.io.Files;
     
     @Test
    -public class DslAndRebindYamlTest extends AbstractYamlTest {
    +public class DslAndRebindYamlTest extends AbstractYamlRebindTest {
    --- End diff --
    
    The `AbstractYamlRebindTest` does the rebind correctly - it makes sure the `mgmt` field is updated on rebind, so subsequent provisioning uses the new application context. Before this, `testDslSensorFromClass` was not doing what you'd expect - the second call returned the app from the first call to `doTestOnEntityWithSensor`, so the subsequent assertions weren't useful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #416: Refactor and add to DSL tests

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/416


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #416: Refactor and add to DSL tests

Posted by googlielmo <gi...@git.apache.org>.

Github user googlielmo commented on the issue:

    https://github.com/apache/brooklyn-server/pull/416
  
    Builds correctly. LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---