[GitHub] [spark] LantaoJin commented on a change in pull request #21502: [SPARK-22575][SQL] Add destroy to Dataset

[GitBox <gi...@apache.org>]

LantaoJin commented on a change in pull request #21502: [SPARK-22575][SQL] Add destroy to Dataset
URL: https://github.com/apache/spark/pull/21502#discussion_r273950542
 
 

 ##########
 File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
 ##########
 @@ -288,6 +288,9 @@ private[hive] class SparkExecuteStatementOperation(
     if (statementId != null) {
       sqlContext.sparkContext.cancelJobGroup(statementId)
     }
+    if (result != null) {
+      result.destroy()
 
 Review comment:
   Seems this is the entrance of resource cleaning. Could this cover the scenario of container killed? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org