You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/11 04:40:42 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #3452: [DO_NOT_MERGE] Setting default for hoodie.bloom/simple.index.update.partition.path to true
nsivabalan opened a new pull request #3452:
URL: https://github.com/apache/hudi/pull/3452
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3452: [HUDI-2151] Flipping defaults
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
}, {
"hash" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676",
"triggerID" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"triggerType" : "PUSH"
}, {
"hash" : "86e68626797e4970d3836934bc170c8bc97bf452",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1684",
"triggerID" : "86e68626797e4970d3836934bc170c8bc97bf452",
"triggerType" : "PUSH"
}, {
"hash" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1686",
"triggerID" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"triggerType" : "PUSH"
}, {
"hash" : "d7d8f8ff01270ae5690ff8f5e25760920c7e20a6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1691",
"triggerID" : "d7d8f8ff01270ae5690ff8f5e25760920c7e20a6",
"triggerType" : "PUSH"
}, {
"hash" : "43811935c8aa3a5ca08905edd66bb6312601abaf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "43811935c8aa3a5ca08905edd66bb6312601abaf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d7d8f8ff01270ae5690ff8f5e25760920c7e20a6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1691)
* 43811935c8aa3a5ca08905edd66bb6312601abaf UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3452: [DO_NOT_MERGE] Setting default for hoodie.bloom/simple.index.update.partition.path to true
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
}, {
"hash" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676",
"triggerID" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"triggerType" : "PUSH"
}, {
"hash" : "86e68626797e4970d3836934bc170c8bc97bf452",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1684",
"triggerID" : "86e68626797e4970d3836934bc170c8bc97bf452",
"triggerType" : "PUSH"
}, {
"hash" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86e68626797e4970d3836934bc170c8bc97bf452 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1684)
* 2998d75e7afaaddc7656943e072d23dbc974d0b4 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3452: [DO_NOT_MERGE] Setting default for hoodie.bloom/simple.index.update.partition.path to true
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
}, {
"hash" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642)
* 9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3452: [HUDI-2151] Flipping defaults
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#discussion_r688771638
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
##########
@@ -81,7 +81,7 @@
public static final ConfigProperty<HoodieTableVersion> HOODIE_TABLE_VERSION_PROP = ConfigProperty
.key("hoodie.table.version")
- .defaultValue(HoodieTableVersion.ZERO)
+ .defaultValue(HoodieTableVersion.ONE)
Review comment:
I don't see the upgrade kicking in actually. So, here is what is happening.
if hoodie.properties does not have any table version, this default value kicks in.
So, for a table created with 052, if I use this patch to trigger an insert, I don't see an upgrade kicking in. bcoz, the hoodie.props will not have any table version and so this default gets picked up.
Looks like, we might have to leave the default version as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3452: [DO_NOT_MERGE] Setting default for hoodie.bloom/simple.index.update.partition.path to true
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
}, {
"hash" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676",
"triggerID" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642)
* 9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3452: [HUDI-2151] Flipping defaults
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
}, {
"hash" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676",
"triggerID" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"triggerType" : "PUSH"
}, {
"hash" : "86e68626797e4970d3836934bc170c8bc97bf452",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1684",
"triggerID" : "86e68626797e4970d3836934bc170c8bc97bf452",
"triggerType" : "PUSH"
}, {
"hash" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1686",
"triggerID" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"triggerType" : "PUSH"
}, {
"hash" : "d7d8f8ff01270ae5690ff8f5e25760920c7e20a6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1691",
"triggerID" : "d7d8f8ff01270ae5690ff8f5e25760920c7e20a6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2998d75e7afaaddc7656943e072d23dbc974d0b4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1686)
* d7d8f8ff01270ae5690ff8f5e25760920c7e20a6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1691)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3452: [HUDI-2151] Flipping defaults
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
}, {
"hash" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676",
"triggerID" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"triggerType" : "PUSH"
}, {
"hash" : "86e68626797e4970d3836934bc170c8bc97bf452",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1684",
"triggerID" : "86e68626797e4970d3836934bc170c8bc97bf452",
"triggerType" : "PUSH"
}, {
"hash" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1686",
"triggerID" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"triggerType" : "PUSH"
}, {
"hash" : "d7d8f8ff01270ae5690ff8f5e25760920c7e20a6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d7d8f8ff01270ae5690ff8f5e25760920c7e20a6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2998d75e7afaaddc7656943e072d23dbc974d0b4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1686)
* d7d8f8ff01270ae5690ff8f5e25760920c7e20a6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3452: [HUDI-2151] Flipping defaults
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
}, {
"hash" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676",
"triggerID" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"triggerType" : "PUSH"
}, {
"hash" : "86e68626797e4970d3836934bc170c8bc97bf452",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1684",
"triggerID" : "86e68626797e4970d3836934bc170c8bc97bf452",
"triggerType" : "PUSH"
}, {
"hash" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1686",
"triggerID" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"triggerType" : "PUSH"
}, {
"hash" : "d7d8f8ff01270ae5690ff8f5e25760920c7e20a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1691",
"triggerID" : "d7d8f8ff01270ae5690ff8f5e25760920c7e20a6",
"triggerType" : "PUSH"
}, {
"hash" : "43811935c8aa3a5ca08905edd66bb6312601abaf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1722",
"triggerID" : "43811935c8aa3a5ca08905edd66bb6312601abaf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43811935c8aa3a5ca08905edd66bb6312601abaf Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1722)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3452: [DO_NOT_MERGE] Setting default for hoodie.bloom/simple.index.update.partition.path to true
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
}, {
"hash" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676",
"triggerID" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3452: [DO_NOT_MERGE] Setting default for hoodie.bloom/simple.index.update.partition.path to true
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
}, {
"hash" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676",
"triggerID" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"triggerType" : "PUSH"
}, {
"hash" : "86e68626797e4970d3836934bc170c8bc97bf452",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1684",
"triggerID" : "86e68626797e4970d3836934bc170c8bc97bf452",
"triggerType" : "PUSH"
}, {
"hash" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1686",
"triggerID" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2998d75e7afaaddc7656943e072d23dbc974d0b4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1686)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3452: [HUDI-2151] Flipping defaults
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
}, {
"hash" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676",
"triggerID" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"triggerType" : "PUSH"
}, {
"hash" : "86e68626797e4970d3836934bc170c8bc97bf452",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1684",
"triggerID" : "86e68626797e4970d3836934bc170c8bc97bf452",
"triggerType" : "PUSH"
}, {
"hash" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1686",
"triggerID" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"triggerType" : "PUSH"
}, {
"hash" : "d7d8f8ff01270ae5690ff8f5e25760920c7e20a6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1691",
"triggerID" : "d7d8f8ff01270ae5690ff8f5e25760920c7e20a6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d7d8f8ff01270ae5690ff8f5e25760920c7e20a6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1691)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3452: [DO_NOT_MERGE] Setting default for hoodie.bloom/simple.index.update.partition.path to true
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
}, {
"hash" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676",
"triggerID" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"triggerType" : "PUSH"
}, {
"hash" : "86e68626797e4970d3836934bc170c8bc97bf452",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1684",
"triggerID" : "86e68626797e4970d3836934bc170c8bc97bf452",
"triggerType" : "PUSH"
}, {
"hash" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676)
* 86e68626797e4970d3836934bc170c8bc97bf452 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1684)
* 2998d75e7afaaddc7656943e072d23dbc974d0b4 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3452: [DO_NOT_MERGE] Setting default for hoodie.bloom/simple.index.update.partition.path to true
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3452: [DO_NOT_MERGE] Setting default for hoodie.bloom/simple.index.update.partition.path to true
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3452: [DO_NOT_MERGE] Setting default for hoodie.bloom/simple.index.update.partition.path to true
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
}, {
"hash" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676",
"triggerID" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"triggerType" : "PUSH"
}, {
"hash" : "86e68626797e4970d3836934bc170c8bc97bf452",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1684",
"triggerID" : "86e68626797e4970d3836934bc170c8bc97bf452",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676)
* 86e68626797e4970d3836934bc170c8bc97bf452 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1684)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #3452: [HUDI-2151] Flipping defaults
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#discussion_r688787514
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
##########
@@ -81,7 +81,7 @@
public static final ConfigProperty<HoodieTableVersion> HOODIE_TABLE_VERSION_PROP = ConfigProperty
.key("hoodie.table.version")
- .defaultValue(HoodieTableVersion.ZERO)
+ .defaultValue(HoodieTableVersion.ONE)
Review comment:
lets leave it as is and async this after
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3452: [DO_NOT_MERGE] Setting default for hoodie.bloom/simple.index.update.partition.path to true
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
}, {
"hash" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676",
"triggerID" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"triggerType" : "PUSH"
}, {
"hash" : "86e68626797e4970d3836934bc170c8bc97bf452",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "86e68626797e4970d3836934bc170c8bc97bf452",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676)
* 86e68626797e4970d3836934bc170c8bc97bf452 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3452: [HUDI-2151] Flipping defaults
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#discussion_r688481093
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
##########
@@ -81,7 +81,7 @@
public static final ConfigProperty<HoodieTableVersion> HOODIE_TABLE_VERSION_PROP = ConfigProperty
.key("hoodie.table.version")
- .defaultValue(HoodieTableVersion.ZERO)
+ .defaultValue(HoodieTableVersion.ONE)
Review comment:
yes, HoodieTableMetaClient.PropertyBuilder set table version as below.
```
tableConfig.setValue(HoodieTableConfig.HOODIE_TABLE_VERSION_PROP,
String.valueOf(HoodieTableVersion.current().versionCode()));
```
So, this default value is actually of no use. But will see how to test this out.
I guess, I might have to generate a table w/ 0.5.2. And then try to use this patch and see if upgrade happens. Upgrade here refers to tableversion 0 to 1 which happened w/ 0.6.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3452: [HUDI-2151] Flipping defaults
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
}, {
"hash" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676",
"triggerID" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"triggerType" : "PUSH"
}, {
"hash" : "86e68626797e4970d3836934bc170c8bc97bf452",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1684",
"triggerID" : "86e68626797e4970d3836934bc170c8bc97bf452",
"triggerType" : "PUSH"
}, {
"hash" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1686",
"triggerID" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"triggerType" : "PUSH"
}, {
"hash" : "d7d8f8ff01270ae5690ff8f5e25760920c7e20a6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1691",
"triggerID" : "d7d8f8ff01270ae5690ff8f5e25760920c7e20a6",
"triggerType" : "PUSH"
}, {
"hash" : "43811935c8aa3a5ca08905edd66bb6312601abaf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1722",
"triggerID" : "43811935c8aa3a5ca08905edd66bb6312601abaf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d7d8f8ff01270ae5690ff8f5e25760920c7e20a6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1691)
* 43811935c8aa3a5ca08905edd66bb6312601abaf Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1722)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3452: [DO_NOT_MERGE] Setting default for hoodie.bloom/simple.index.update.partition.path to true
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
}, {
"hash" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1676",
"triggerID" : "9bad43d99ac6adbfc1d0ce30175ec1fd04dcc434",
"triggerType" : "PUSH"
}, {
"hash" : "86e68626797e4970d3836934bc170c8bc97bf452",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1684",
"triggerID" : "86e68626797e4970d3836934bc170c8bc97bf452",
"triggerType" : "PUSH"
}, {
"hash" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1686",
"triggerID" : "2998d75e7afaaddc7656943e072d23dbc974d0b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86e68626797e4970d3836934bc170c8bc97bf452 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1684)
* 2998d75e7afaaddc7656943e072d23dbc974d0b4 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1686)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #3452: [HUDI-2151] Flipping defaults
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#discussion_r688137468
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
##########
@@ -81,7 +81,7 @@
public static final ConfigProperty<HoodieTableVersion> HOODIE_TABLE_VERSION_PROP = ConfigProperty
.key("hoodie.table.version")
- .defaultValue(HoodieTableVersion.ZERO)
+ .defaultValue(HoodieTableVersion.ONE)
Review comment:
can you ensure this is compatible on an existing table at version 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #3452: [HUDI-2151] Flipping defaults
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3452:
URL: https://github.com/apache/hudi/pull/3452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3452: [DO_NOT_MERGE] Setting default for hoodie.bloom/simple.index.update.partition.path to true
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#issuecomment-896496147
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642",
"triggerID" : "f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f3bf0ef9875bb41c458d3a2c3838d2aed0a8ca Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1642)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org