You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2014/02/28 19:46:20 UTC

[jira] [Updated] (HDFS-6030) Remove an unused constructor in INode.java

     [ https://issues.apache.org/jira/browse/HDFS-6030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin Patrick McCabe updated HDFS-6030:
---------------------------------------

    Summary: Remove an unused constructor in INode.java  (was: to remove a redundant/unused constructor in INode.java)

> Remove an unused constructor in INode.java
> ------------------------------------------
>
>                 Key: HDFS-6030
>                 URL: https://issues.apache.org/jira/browse/HDFS-6030
>             Project: Hadoop HDFS
>          Issue Type: Task
>    Affects Versions: 2.3.0
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>            Priority: Trivial
>         Attachments: HDFS-6030.001.patch
>
>
> When I look at fix of HDFS-4879, I noticed that class BlocksMapUpdateInfo in INode.java,  has a constructor that still uses ArrayList<Block> (which HDFS-4879 tries to replace with ChunkedArrayList for better memory efficiency)
> {code}
>     public static class BlocksMapUpdateInfo { 
>     ...... 
>     public BlocksMapUpdateInfo(List<Block> toDeleteList) {
>       this.toDeleteList = toDeleteList == null ? new ArrayList<Block>()
>           : toDeleteList;
>     }
>     ......
>     }
> {code}
> It turns out that this constructor is not used anywhere (thanks [~cmccabe] for pointing this out). I'm filing this JIRA to remove it.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)