You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Eric Gillespie <ep...@pretzelnet.org> on 2003/01/24 02:47:09 UTC
[PATCH] Re: Problem with apr_proc_wait and/or svn_io_run_cmd
Jeff Trawick <tr...@attglobal.net> writes:
> I can live with that :)
>
> (yes, I'm psychologically damaged by some of the xyy specials that cutified
> something in APR but chopped off interesting Unix-specific code at the
> knees)
OK, i'm not sure what you're talking about with the "xyy
specials" (i am not that familiar with APR), but the following
patch solves the problem i reported. The Subversion test suite
now passess completely with ra_svn after applying this patch to
APR.
CCing the Subversion list again because if this patch is accepted
Subversion will NOT need to be changed.
Index: proc.c
===================================================================
RCS file: /home/cvspublic/apr/threadproc/unix/proc.c,v
retrieving revision 1.62
diff -a -u -r1.62 proc.c
--- proc.c 6 Jan 2003 23:44:38 -0000 1.62
+++ proc.c 24 Jan 2003 01:43:42 -0000
@@ -474,7 +474,11 @@
waitpid_options |= WNOHANG;
}
- if ((pstatus = waitpid(proc->pid, &exit_int, waitpid_options)) > 0) {
+ do {
+ pstatus = waitpid(proc->pid, &exit_int, waitpid_options);
+ } while (pstatus < 0 && errno == EINTR);
+
+ if (pstatus > 0) {
proc->pid = pstatus;
if (WIFEXITED(exit_int)) {
Re: [PATCH] Re: Problem with apr_proc_wait and/or svn_io_run_cmd
Posted by Sander Roobol <ph...@wanadoo.nl>.
On Wed, Mar 05, 2003 at 05:49:28PM +0000, Thom May wrote:
> * Sander Roobol (phy@wanadoo.nl) wrote :
> > So... what happend to this? It looks to me that the patch didn't made it
> > into APR, so my question is, has this issue (whatever it might be) been
> > addressed in Subversion? (I'm intentionally not Cc'ing the APR list
> > because I don't think they care about this.)
> >
> It's still on my radar for APR; I need to get the httpd test suite set up
> (just got back from holiday) so I can confirm that it doesn't break anything
> in that project and then I'll be pretty happy to commit it...
> -Thom
I filed issue #1234 for this problem.
Sander
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: Problem with apr_proc_wait and/or svn_io_run_cmd
Posted by Thom May <th...@planetarytramp.net>.
* Sander Roobol (phy@wanadoo.nl) wrote :
> On Thu, Jan 23, 2003 at 08:47:09PM -0500, Eric Gillespie wrote:
> >
> > OK, i'm not sure what you're talking about with the "xyy
> > specials" (i am not that familiar with APR), but the following
> > patch solves the problem i reported. The Subversion test suite
> > now passess completely with ra_svn after applying this patch to
> > APR.
> >
> > CCing the Subversion list again because if this patch is accepted
> > Subversion will NOT need to be changed.
>
> So... what happend to this? It looks to me that the patch didn't made it
> into APR, so my question is, has this issue (whatever it might be) been
> addressed in Subversion? (I'm intentionally not Cc'ing the APR list
> because I don't think they care about this.)
>
It's still on my radar for APR; I need to get the httpd test suite set up
(just got back from holiday) so I can confirm that it doesn't break anything
in that project and then I'll be pretty happy to commit it...
-Thom
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: Problem with apr_proc_wait and/or svn_io_run_cmd
Posted by Sander Roobol <ph...@wanadoo.nl>.
On Thu, Jan 23, 2003 at 08:47:09PM -0500, Eric Gillespie wrote:
> Jeff Trawick <tr...@attglobal.net> writes:
>
> > I can live with that :)
> >
> > (yes, I'm psychologically damaged by some of the xyy specials that cutified
> > something in APR but chopped off interesting Unix-specific code at the
> > knees)
>
> OK, i'm not sure what you're talking about with the "xyy
> specials" (i am not that familiar with APR), but the following
> patch solves the problem i reported. The Subversion test suite
> now passess completely with ra_svn after applying this patch to
> APR.
>
> CCing the Subversion list again because if this patch is accepted
> Subversion will NOT need to be changed.
So... what happend to this? It looks to me that the patch didn't made it
into APR, so my question is, has this issue (whatever it might be) been
addressed in Subversion? (I'm intentionally not Cc'ing the APR list
because I don't think they care about this.)
Sander
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org